Skip to content

[release-4.21] OCPBUGS-113732: make cloud provider fields optional during operator install - #17091

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.21from
ericahinkleRH:OCPBUGS-111417-4.21
Aug 25, 2026
Merged

[release-4.21] OCPBUGS-113732: make cloud provider fields optional during operator install#17091
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.21from
ericahinkleRH:OCPBUGS-111417-4.21

Conversation

@ericahinkleRH

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick of #17014 (release-4.22) for release-4.21.

On Workload Identity / Federated Identity clusters (AWS STS, Azure WI, GCP WI), the Console UI incorrectly forces users to provide cloud-specific credentials before installing operators that have token-auth-* CSV annotations. These annotations indicate capability, not a mandatory requirement.

This fix makes the cloud provider configuration fields optional so users can install operators first and configure cloud credentials as a Day-2 task.

Note: The 4.21 branch does not include RESOURCEGROUP for Azure, so this cherry-pick includes only the 3 Azure env vars (CLIENTID, TENANTID, SUBSCRIPTIONID) vs 4 on 4.22.

Changes

  • Removed required attribute and co-required CSS class from cloud provider input fields
  • Updated subscription creation to filter out empty env vars before setting spec.config
  • Removed form validation that blocked submission when cloud credential fields were empty

Test plan

  • Install an operator with token-auth-* CSV annotations on a WI/FI cluster with all cloud fields empty — subscription should be created without spec.config
  • Install with partial cloud fields — only populated values should appear in spec.config.env
  • Install with all cloud fields filled — behavior unchanged from before
  • Verify non-WI cluster operator installation is unaffected

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ericahinkleRH: This pull request references Jira Issue OCPBUGS-111417, which is invalid:

  • expected the bug to target either version "4.21.z." or "openshift-4.21.z.", but it targets "4.22.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-111921 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-111921 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #17014 (release-4.22) for release-4.21.

On Workload Identity / Federated Identity clusters (AWS STS, Azure WI, GCP WI), the Console UI incorrectly forces users to provide cloud-specific credentials before installing operators that have token-auth-* CSV annotations. These annotations indicate capability, not a mandatory requirement.

This fix makes the cloud provider configuration fields optional so users can install operators first and configure cloud credentials as a Day-2 task.

Note: The 4.21 branch does not include RESOURCEGROUP for Azure, so this cherry-pick includes only the 3 Azure env vars (CLIENTID, TENANTID, SUBSCRIPTIONID) vs 4 on 4.22.

Changes

  • Removed required attribute and co-required CSS class from cloud provider input fields
  • Updated subscription creation to filter out empty env vars before setting spec.config
  • Removed form validation that blocked submission when cloud credential fields were empty

Test plan

  • Install an operator with token-auth-* CSV annotations on a WI/FI cluster with all cloud fields empty — subscription should be created without spec.config
  • Install with partial cloud fields — only populated values should appear in spec.config.env
  • Install with all cloud fields filled — behavior unchanged from before
  • Verify non-WI cluster operator installation is unaffected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: aefb700c-b4f4-45cb-aaaa-4bb5e166b5f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from TheRealJon and cajieh August 25, 2026 13:38
@openshift-ci openshift-ci Bot added the component/olm Related to OLM label Aug 25, 2026
@ericahinkleRH ericahinkleRH changed the title [release-4.21] OCPBUGS-111417: make cloud provider fields optional during operator install [release-4.21] OCPBUGS-113732: make cloud provider fields optional during operator install Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ericahinkleRH: This pull request references Jira Issue OCPBUGS-113732, which is invalid:

  • expected Jira Issue OCPBUGS-113732 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of #17014 (release-4.22) for release-4.21.

On Workload Identity / Federated Identity clusters (AWS STS, Azure WI, GCP WI), the Console UI incorrectly forces users to provide cloud-specific credentials before installing operators that have token-auth-* CSV annotations. These annotations indicate capability, not a mandatory requirement.

This fix makes the cloud provider configuration fields optional so users can install operators first and configure cloud credentials as a Day-2 task.

Note: The 4.21 branch does not include RESOURCEGROUP for Azure, so this cherry-pick includes only the 3 Azure env vars (CLIENTID, TENANTID, SUBSCRIPTIONID) vs 4 on 4.22.

Changes

  • Removed required attribute and co-required CSS class from cloud provider input fields
  • Updated subscription creation to filter out empty env vars before setting spec.config
  • Removed form validation that blocked submission when cloud credential fields were empty

Test plan

  • Install an operator with token-auth-* CSV annotations on a WI/FI cluster with all cloud fields empty — subscription should be created without spec.config
  • Install with partial cloud fields — only populated values should appear in spec.config.env
  • Install with all cloud fields filled — behavior unchanged from before
  • Verify non-WI cluster operator installation is unaffected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ericahinkleRH

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@ericahinkleRH

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ericahinkleRH: This pull request references Jira Issue OCPBUGS-113732, which is invalid:

  • expected dependent Jira Issue OCPBUGS-111417 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ericahinkleRH

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ericahinkleRH: This pull request references Jira Issue OCPBUGS-113732, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-111417 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-111417 targets the "4.22.z" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@ericahinkleRH: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 25, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericahinkleRH, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@ericahinkleRH

Copy link
Copy Markdown
Contributor Author

/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 25, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3af0048 into openshift:release-4.21 Aug 25, 2026
8 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ericahinkleRH: Jira Issue Verification Checks: Jira Issue OCPBUGS-113732
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-113732 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Cherry-pick of #17014 (release-4.22) for release-4.21.

On Workload Identity / Federated Identity clusters (AWS STS, Azure WI, GCP WI), the Console UI incorrectly forces users to provide cloud-specific credentials before installing operators that have token-auth-* CSV annotations. These annotations indicate capability, not a mandatory requirement.

This fix makes the cloud provider configuration fields optional so users can install operators first and configure cloud credentials as a Day-2 task.

Note: The 4.21 branch does not include RESOURCEGROUP for Azure, so this cherry-pick includes only the 3 Azure env vars (CLIENTID, TENANTID, SUBSCRIPTIONID) vs 4 on 4.22.

Changes

  • Removed required attribute and co-required CSS class from cloud provider input fields
  • Updated subscription creation to filter out empty env vars before setting spec.config
  • Removed form validation that blocked submission when cloud credential fields were empty

Test plan

  • Install an operator with token-auth-* CSV annotations on a WI/FI cluster with all cloud fields empty — subscription should be created without spec.config
  • Install with partial cloud fields — only populated values should appear in spec.config.env
  • Install with all cloud fields filled — behavior unchanged from before
  • Verify non-WI cluster operator installation is unaffected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.21.0-0.nightly-2026-08-26-024503

@ericahinkleRH

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

Copy link
Copy Markdown

@ericahinkleRH: new pull request created: #17098

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/olm Related to OLM jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants