Skip to content

NO-JIRA: [release-4.20] Enable ReadWriteOncePod for Cinder CSI - #17107

Open
kchawlani19 wants to merge 2 commits into
openshift:release-4.20from
kchawlani19:no-jira-16866-cinder-rwop-4.20
Open

NO-JIRA: [release-4.20] Enable ReadWriteOncePod for Cinder CSI#17107
kchawlani19 wants to merge 2 commits into
openshift:release-4.20from
kchawlani19:no-jira-16866-cinder-rwop-4.20

Conversation

@kchawlani19

Copy link
Copy Markdown
Contributor

Analysis / Root cause:
On OpenShift 4.20, the Create PersistentVolumeClaim form greys out ReadWriteOncePod for Cinder CSI. Allowed access modes come from a static map in frontend/public/components/storage/shared.ts; cinder.csi.openstack.org listed only ReadWriteOnce. Creating the same PVC via YAML works. Reported in #16866 against 4.20 IPI on OpenStack 18.

Solution description:
Backport of #16870 plus regression tests:

  • cinder.csi.openstack.org: add ReadWriteOncePod for Filesystem and Block
  • kubernetes.io/cinder: remove duplicate ReadWriteOncePod entries
  • unit tests for the provisioner access-mode helpers

Screenshots / screen recording:
N/A (access-mode dropdown option enablement)

Test setup:
OpenShift 4.20 on OpenStack with a StorageClass whose provisioner is cinder.csi.openstack.org.

Test cases:

  1. Storage → PersistentVolumeClaims → Create PersistentVolumeClaim
  2. Select a Cinder CSI StorageClass
  3. Access mode options include "Read write once pod (RWOP)" alongside "Single user (RWO)"
  4. Create a PVC with RWOP / Filesystem and confirm it binds
  5. Repeat with volume mode Block
  6. Regression: Manila CSI access modes unchanged

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Related to #16866
Backport of #16870
Tests on main: #17105
4.22 backport: #17106

Reviewers and assignees:
/assign spadgett

The Create PVC form greys out RWOP for cinder.csi.openstack.org because
the static provisioner map listed only ReadWriteOnce. YAML already works
on OpenStack 4.20; add RWOP for Filesystem and Block, drop the duplicate
in-tree Cinder entry, and cover the mapping with unit tests.

Backport of openshift#16870. Related to openshift#16866.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@kchawlani19: This pull request explicitly references no jira issue.

Details

In response to this:

Analysis / Root cause:
On OpenShift 4.20, the Create PersistentVolumeClaim form greys out ReadWriteOncePod for Cinder CSI. Allowed access modes come from a static map in frontend/public/components/storage/shared.ts; cinder.csi.openstack.org listed only ReadWriteOnce. Creating the same PVC via YAML works. Reported in #16866 against 4.20 IPI on OpenStack 18.

Solution description:
Backport of #16870 plus regression tests:

  • cinder.csi.openstack.org: add ReadWriteOncePod for Filesystem and Block
  • kubernetes.io/cinder: remove duplicate ReadWriteOncePod entries
  • unit tests for the provisioner access-mode helpers

Screenshots / screen recording:
N/A (access-mode dropdown option enablement)

Test setup:
OpenShift 4.20 on OpenStack with a StorageClass whose provisioner is cinder.csi.openstack.org.

Test cases:

  1. Storage → PersistentVolumeClaims → Create PersistentVolumeClaim
  2. Select a Cinder CSI StorageClass
  3. Access mode options include "Read write once pod (RWOP)" alongside "Single user (RWO)"
  4. Create a PVC with RWOP / Filesystem and confirm it binds
  5. Repeat with volume mode Block
  6. Regression: Manila CSI access modes unchanged

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Related to #16866
Backport of #16870
Tests on main: #17105
4.22 backport: #17106

Reviewers and assignees:
/assign spadgett

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 898d1de8-aba5-47c7-aea5-7aefc6732a13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Leo6Leo and jhadvig August 29, 2026 14:35
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Aug 29, 2026
Match the main-branch tests so jest/valid-title does not fail if this
branch picks up the newer ESLint rule.
@openshift-ci

openshift-ci Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kchawlani19
Once this PR has been reviewed and has the lgtm label, please ask for approval from spadgett. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@kchawlani19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants