Skip to content

OCPBUGS-105419: Upgrade envtest Makefile target in ingress-node-firewall 4.18 - #786

Open
raphaelvrosa wants to merge 2 commits into
openshift:release-4.18from
raphaelvrosa:rel-4.18
Open

OCPBUGS-105419: Upgrade envtest Makefile target in ingress-node-firewall 4.18#786
raphaelvrosa wants to merge 2 commits into
openshift:release-4.18from
raphaelvrosa:rel-4.18

Conversation

@raphaelvrosa

Copy link
Copy Markdown
Contributor

Upgrades envtest Makefile target - Sets it to use go install with 0.19 envtest version. - Updates test Makefile targets to reflect changes in envtest - Other changes come from make test call that automates the updates of base CRD yamls. - Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

Signed-off-by: Raphael Rosa raprosa@redhat.com
(cherry picked from commit 49709f4)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

…0.0 envtest version. - Updates test Makefile targets to reflect changes in envtest - Other changes come from `make test` call that automates the updates of base CRD yamls. - Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

Signed-off-by: Raphael Rosa <raprosa@redhat.com>
(cherry picked from commit 49709f4)
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 598617c7-8639-4805-b667-d3c105c5cad6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raphaelvrosa
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Raphael Rosa <raprosa@redhat.com>
@raphaelvrosa raphaelvrosa changed the title Upgrade envtest Makefile target in ingress-node-firewall 4.18 OCPBUGS-105419: Upgrade envtest Makefile target in ingress-node-firewall 4.18 Sep 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-105419, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-105274 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-105274 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Upgrades envtest Makefile target - Sets it to use go install with 0.19 envtest version. - Updates test Makefile targets to reflect changes in envtest - Other changes come from make test call that automates the updates of base CRD yamls. - Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

Signed-off-by: Raphael Rosa raprosa@redhat.com
(cherry picked from commit 49709f4)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raphaelvrosa

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-105419, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-105274 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-105274 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@raphaelvrosa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants