OCPBUGS-115550: use different INSTALL_INVOKER for unconfigured ignition by zaneb · Pull Request #10848 · openshift/installer

zaneb · 2026-09-02T10:26:51Z

The INSTALL_INVOKER environment variable in assisted-service is now set to agent-installer-postconfig when the agent unconfigured-ignition workflow is used, distinguishing it from the regular agent-installer workflow.

This will show up in installations using the appliance or the OVE installer.

Summary by CodeRabbit

New Features
- The agent installation command now supports an optional suffix for post-configuration workflows.
- Unconfigured installations use the -postconfig suffix automatically.

The INSTALL_INVOKER environment variable in assisted-service is now set to agent-installer-postconfig when the agent unconfigured-ignition workflow is used, distinguishing it from the regular agent-installer workflow. This will show up in installations using the appliance or the OVE installer. Assisted-by: Claude Code

openshift-merge-bot · 2026-09-02T10:26:53Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-09-02T10:26:57Z

@zaneb: This pull request references Jira Issue OCPBUGS-115550, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The INSTALL_INVOKER environment variable in assisted-service is now set to agent-installer-postconfig when the agent unconfigured-ignition workflow is used, distinguishing it from the regular agent-installer workflow.

This will show up in installations using the appliance or the OVE installer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-02T10:27:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

data/data/agent/OWNERS
pkg/asset/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-09-02T10:27:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: de2df5ef-435b-4e1a-a86b-e4d2ac19c583

📥 Commits

Reviewing files that changed from the base of the PR and between c8d2999 and 8dbccff.

📒 Files selected for processing (3)

data/data/agent/files/usr/local/share/assisted-service/assisted-service.env.template
pkg/asset/agent/image/ignition.go
pkg/asset/agent/image/unconfigured_ignition.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

Walkthrough

The agent template data now includes an install-invoker suffix. Unconfigured ignition sets the suffix to -postconfig, and the environment template appends it to agent-installer.

Changes

Install invoker suffix templating

Layer / File(s)	Summary
Template data and install invoker rendering `pkg/asset/agent/image/ignition.go`, `pkg/asset/agent/image/unconfigured_ignition.go`, `data/data/agent/files/usr/local/share/assisted-service/assisted-service.env.template`	`agentTemplateData` defines `InstallInvokerSuffix`. Unconfigured ignition sets it to `-postconfig`. The environment template appends the suffix to `agent-installer`.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 8dbcc

This localized change distinguishes the installer invocation for unconfigured ignition workflows; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the bug and the main change: using a different `INSTALL_INVOKER` value for unconfigured ignition.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only a template value and Go template data plumbing. The commit adds no test files and no `It`, `Describe`, `Context`, `When`, or `Entry` titles. The added `InstallInvok…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only an environment template and two implementation files. It does not add or modify any Ginkgo test code, assertions, waits, setup, or cleanup. Therefore, the stated Gi…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only one environment template and two production Go files. The commit adds no `_test.go` or Ginkgo declarations (`It`, `Describe`, `Context`, or `When`). Therefore, the …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only an environment template and two Go implementation files. The diff adds no Ginkgo e2e tests or other new tests, so the SNO multi-node compatibility check is not appl…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The commit changes only an assisted-service environment template and template-data generation. It adds `InstallInvokerSuffix` and sets `INSTALL_INVOKER` to `agent-installer-postconfig` for uncon…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only a template value, a template-data field, and the `"-postconfig"` assignment. The changed package has no `main`, `init`, `TestMain`, suite setup, `RunSpecs`, `fmt.Pr…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request adds no Ginkgo e2e tests. The diff changes one environment template and two production Go files to set `INSTALL_INVOKER`; it adds no test declarations, IPv4 test assumptions, o…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only a template variable, a template-data field, and the literal suffix "-postconfig". The diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptograp…
Container-Privileges	✅ Passed	PASS: The pull request changes only an assisted-service environment template and Go template data. The diff adds `InstallInvokerSuffix` and renders `agent-installer-postconfig`; it does not modify a c…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive-data logging was introduced. The diff only adds `InstallInvokerSuffix` to template data and sets it to the fixed value `-postconfig`; the template then produces the non-sensitive value `a…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only a template value and Go template data plumbing. The commit adds no test files and no It, Describe, Context, When, or Entry titles. The added InstallInvokerSuffix is the static value "-postconfig" used in configuration generation, not a test name or dynamic test data.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only an environment template and two implementation files. It does not add or modify any Ginkgo test code, assertions, waits, setup, or cleanup. Therefore, the stated Ginkgo test-quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only one environment template and two production Go files. The commit adds no _test.go or Ginkgo declarations (It, Describe, Context, or When). Therefore, the MicroShift test compatibility check has no new e2e test to flag.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only an environment template and two Go implementation files. The diff adds no Ginkgo e2e tests or other new tests, so the SNO multi-node compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The commit changes only an assisted-service environment template and template-data generation. It adds InstallInvokerSuffix and sets INSTALL_INVOKER to agent-installer-postconfig for unconfigured ignition. The exact diff adds no deployment manifest, operator/controller scheduling logic, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore the topology-aware scheduling check is not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only a template value, a template-data field, and the "-postconfig" assignment. The changed package has no main, init, TestMain, suite setup, RunSpecs, fmt.Print*, klog, or stdout writes. The changes do not introduce non-JSON stdout from an OTE process.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request adds no Ginkgo e2e tests. The diff changes one environment template and two production Go files to set INSTALL_INVOKER; it adds no test declarations, IPv4 test assumptions, or external connectivity requirements. The pre-existing DB_HOST=127.0.0.1 is unchanged and is not a test change.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only a template variable, a template-data field, and the literal suffix "-postconfig". The diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret comparison logic. The crypto API searches in the changed Go files also found no matches.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only an assisted-service environment template and Go template data. The diff adds InstallInvokerSuffix and renders agent-installer-postconfig; it does not modify a container or Kubernetes manifest. No changed line introduces privileged: true, host namespaces, SYS_ADMIN, allowPrivilegeEscalation: true, or an unjustified root setting.

Full details: No-Sensitive-Data-In-Logs

Explanation

No sensitive-data logging was introduced. The diff only adds InstallInvokerSuffix to template data and sets it to the fixed value -postconfig; the template then produces the non-sensitive value agent-installer-postconfig. The affected files contain no new log calls. Existing logs, including the infra-env ID and rendezvous IP, are unchanged and are not caused by this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-09-02T10:28:11Z

@zaneb: This pull request references Jira Issue OCPBUGS-115550, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.1.0) matches configured target version for branch (5.1.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

The INSTALL_INVOKER environment variable in assisted-service is now set to agent-installer-postconfig when the agent unconfigured-ignition workflow is used, distinguishing it from the regular agent-installer workflow.

This will show up in installations using the appliance or the OVE installer.

Summary by CodeRabbit

New Features

The agent installation command now supports an optional suffix for post-configuration workflows.

Unconfigured installations use the -postconfig suffix automatically.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

zaneb · 2026-09-04T05:19:41Z

/retest-required

andfasano · 2026-09-07T09:58:39Z

/pipeline required

openshift-merge-bot · 2026-09-07T09:58:43Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agent-4control-ipv4
/test e2e-agent-5control-ipv4
/test e2e-agent-compact-ipv4
/test e2e-agent-compact-ipv4-appliance-diskimage
/test e2e-agent-compact-ipv4-iso-no-registry
/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-compact-ipv6-minimaliso
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv4-pxe
/test e2e-agent-sno-ipv6
/test e2e-agent-two-node-fencing-ipv4

openshift-ci · 2026-09-07T12:26:24Z

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-5control-ipv4	`8dbccff`	link	false	`/test e2e-agent-5control-ipv4`
ci/prow/e2e-agent-sno-ipv4-pxe	`8dbccff`	link	false	`/test e2e-agent-sno-ipv4-pxe`
ci/prow/e2e-agent-compact-ipv4-iso-no-registry	`8dbccff`	link	false	`/test e2e-agent-compact-ipv4-iso-no-registry`
ci/prow/e2e-agent-compact-ipv6-minimaliso	`8dbccff`	link	false	`/test e2e-agent-compact-ipv6-minimaliso`
ci/prow/e2e-agent-compact-ipv4-none-platform	`8dbccff`	link	false	`/test e2e-agent-compact-ipv4-none-platform`
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	`8dbccff`	link	false	`/test e2e-agent-compact-ipv4-appliance-diskimage`
ci/prow/e2e-agent-two-node-fencing-ipv4	`8dbccff`	link	false	`/test e2e-agent-two-node-fencing-ipv4`
ci/prow/e2e-agent-ha-dualstack	`8dbccff`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/e2e-agent-sno-ipv6	`8dbccff`	link	false	`/test e2e-agent-sno-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

zaneb · 2026-09-08T23:41:58Z

/retest-required

zaneb · 2026-09-09T03:20:03Z

/cc @andfasano

andfasano · 2026-09-09T11:31:35Z

 EPHEMERAL_INSTALLER_CLUSTER_TLS_CERTS_OVERRIDE_DIR=/opt/agent/tls
 HW_VALIDATOR_REQUIREMENTS=TO_BE_REPLACED_BY_SYSTEMD
-INSTALL_INVOKER=agent-installer
+INSTALL_INVOKER=agent-installer{{.InstallInvokerSuffix}}


Currently in Assisted Service there's an exact string match for the specific ABI branches (see repo:openshift/assisted-service "agent-installer"), and also in Assisted Installer (see https://github.com/openshift/assisted-installer/blob/d4580efc20c260403b055a58368b1c12642dd80e/src/common/common.go#L40).
If we want to distinguish the different workflows then I think we'll need to have a less strict check in those repos first (ie, checking the invoker string begins with "agent-installer" should be good enough to cover all the cases)

ugh, good point I completely forgot about those :(

zaneb · 2026-09-09T23:07:27Z

/hold

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 2, 2026

openshift-ci Bot requested review from andfasano and pawanpinjarkar September 2, 2026 10:27

andfasano reviewed Sep 9, 2026

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2026

Uh oh!

Conversation

zaneb commented Sep 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

openshift-ci-robot commented Sep 2, 2026

Uh oh!

openshift-ci Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-ci-robot commented Sep 2, 2026

Summary by CodeRabbit

Uh oh!

zaneb commented Sep 4, 2026

Uh oh!

andfasano commented Sep 7, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 7, 2026

Uh oh!

openshift-ci Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaneb commented Sep 8, 2026

Uh oh!

zaneb commented Sep 9, 2026

Uh oh!

andfasano Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

zaneb Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

zaneb commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zaneb commented Sep 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 2, 2026 •

edited

Loading

openshift-ci Bot commented Sep 7, 2026 •

edited

Loading