CORS-4540: Disallow AMD SEV instances in GCP

[bgartzi]

Users requiring confidential VMs should use AMD SEV-SNP and Intel TDX instead.

This drops "Enabled" and "AMDEncryptedVirtualization" from the values supported for gcp's confidentialCompute field, which will be now rejected during install-config.yaml validation.

openshift/api changes will come later in time once capi/mapi are discussed.

Summary by CodeRabbit

• Changes
  • GCP confidential computing configuration now supports SEV-SNP and TDX options.
  • The Enabled and AMD encrypted virtualization options are no longer accepted.
  • Validation now rejects unsupported confidential computing technologies and continues checking compatible machine types for the remaining options.
  • Documentation for available confidential computing choices has been updated accordingly.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@bgartzi: This pull request references CORS-4540 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Users requiring confidential VMs should use AMD SEV-SNP and Intel TDX instead.

This drops "Enabled" and "AMDEncryptedVirtualization" from the values supported for gcp's confidentialCompute field, which will be now rejected during install-config.yaml validation.

openshift/api changes will come later in time once capi/mapi are discussed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @bgartzi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 14534f40-da7d-4145-adcd-5ae60c86edde

📥 Commits

Reviewing files that changed from the base of the PR and between 850b03b and 579554d.

📒 Files selected for processing (3)

• pkg/asset/installconfig/gcp/validation.go
• pkg/asset/installconfig/gcp/validation_test.go
• pkg/types/gcp/machinepools.go

💤 Files with no reviewable changes (1)

• pkg/types/gcp/machinepools.go

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

GCP confidential-compute support now keeps only SEV-SNP and TDX policies. Validation uses the policy value directly and rejects Enabled and AMDEncryptedVirtualization as unknown technologies.

Changes

GCP Confidential Compute Policies

Layer / File(s)	Summary
Remove unsupported policy definitions pkg/types/gcp/machinepools.go	Removes the Enabled feature, AMD SEV policy constant, SEV machine-type mapping, and related field documentation.
Validate supported confidential-compute policies pkg/asset/installconfig/gcp/validation.go, pkg/asset/installconfig/gcp/validation_test.go	Uses the confidential-compute value directly for machine support lookup. Tests now expect unknown-technology errors for Enabled and AMDEncryptedVirtualization.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 57955

GCP install configuration validation now rejects the unsupported Enabled and AMDEncryptedVirtualization confidential-compute values while retaining supported policies. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: disallowing AMD SEV instances in GCP.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No unstable test title was introduced. The changed file uses Go testing.T.Run, not Ginkgo It/Describe/Context/When. The affected subtest names are literal strings stored in the static `cases…
Test Structure And Quality	✅ Passed	PASS: The changed test file does not contain Ginkgo code. It uses Go testing, testify/assert, and table-driven t.Run cases. The added cases perform no cluster operations, create no resources, an…
Microshift Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The only changed test file uses Go's testing package and table-driven t.Run tests. The changed files contain no Ginkgo markers or MicroShift-incomp…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS — The pull request adds no new Ginkgo e2e tests. The only test changes are edits to the existing Go testing.T table in pkg/asset/installconfig/gcp/validation_test.go; the implementation and t…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only GCP install-config validation, validation tests, and GCP machine-pool type constants and documentation. The exact diff adds no deployment manifests, operator/contro…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only GCP validation, tests, and type constants. The exact diff adds no fmt.Print*, log.Print*, klog, os.Stdout, RunSpecs, suite setup, main, or init code. …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The only test changes are table-driven cases in pkg/asset/installconfig/gcp/validation_test.go, which uses Go testing and has no added It, `Descr…
No-Weak-Crypto	✅ Passed	PASS — The pull request changes GCP confidential-compute validation and policy data only. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage. They add no crypto API calls, cu…
Container-Privileges	✅ Passed	PASS. The pull request changes only three Go files related to GCP confidential-compute validation and tests. The exact diff adds no container or Kubernetes manifest fields and contains no privileged, …
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request adds no logging. The exact diff only changes confidential-compute validation, tests, constants, map entries, and comments. The affected validation path returns field errors and …

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rochacbruno for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/gcp/OWNERS
• pkg/types/gcp/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment