[release-5.0] OCPBUGS-122006: Warn about ignored install-config fields in ABI

[openshift-cherrypick-robot]

This is an automated cherry-pick of #10646

/assign zaneb

Summary by CodeRabbit

• Bug Fixes
  • Added warnings when disk setup configuration is ignored for compute pools or the control plane.
  • Added a warning when an OVN-Kubernetes IPv4 internal join subnet is configured but ignored.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8feea20d-b5e6-4b90-84d2-21d7dbdda989

📥 Commits

Reviewing files that changed from the base of the PR and between b6f1197 and 964d77c.

📒 Files selected for processing (1)

• pkg/asset/agent/installconfig.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The installer now logs warnings for ignored disk setup configuration in compute pools and the control plane. It also warns when an OVN-Kubernetes IPv4 internal join subnet is configured.

Changes

Ignored configuration warnings

Layer / File(s)	Summary
Add ignored configuration warnings pkg/asset/agent/installconfig.go	warnUnusedConfig now reports compute pool and control-plane diskSetup configuration. It also reports a configured OVN-Kubernetes IPv4 internalJoinSubnet.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 964d7

Agent-based installations now warn when unsupported disk setup or OVN internal join subnet settings are ignored. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the release branch, bug reference, and main change: warning about ignored install-config fields during ABI installation.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only pkg/asset/agent/installconfig.go. The 18 added lines add ignored-configuration warnings; they do not add or modify Ginkgo tests or test titles. No It, `Describe…
Test Structure And Quality	✅ Passed	PASS: The full pull-request range changes only pkg/asset/agent/installconfig.go and adds 18 lines. It changes no test file and introduces no Ginkgo constructs such as It, BeforeEach, AfterEach…
Microshift Test Compatibility	✅ Passed	The pull request changes only pkg/asset/agent/installconfig.go and adds warning logic. The full two-commit diff adds no test files and no Ginkgo constructs such as It, Describe, Context, or `W…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only pkg/asset/agent/installconfig.go. The two commits add warnings for ignored install-config fields and add no Ginkgo tests or test wrappers. Therefore, the SNO multi-node…
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only pkg/asset/agent/installconfig.go. The exact HEAD~2..HEAD diff adds logrus.Warnf calls for ignored diskSetup and OVN internalJoinSubnet values. It adds no deploy…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request adds only logrus.Warnf calls in warnUnusedConfig. It adds no stdout write. The changed path runs in openshift-install, which sets logrus output to io.Discard and sends i…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes only pkg/asset/agent/installconfig.go. The diff adds warning logic inside warnUnusedConfig; it adds no Ginkgo e2e tests or other test code. Therefore, the IPv4 and e…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only pkg/asset/agent/installconfig.go. The added code checks configuration fields and emits logrus.Warnf messages. The exact diff introduces no MD5, SHA1, DES, RC4, …
Container-Privileges	✅ Passed	PASS. The complete PR diff changes only pkg/asset/agent/installconfig.go. The additions log ignored diskSetup and internalJoinSubnet values. No container or Kubernetes manifest changes exist, an…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request adds two warnings for non-sensitive configuration. The new diskSetup warnings log only the field path and the fixed text is ignored; they do not log disk contents such as `platfor…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-91640 has been cloned as Jira Issue OCPBUGS-122006. Will retitle bug to link to clone.
/retitle [release-5.0] OCPBUGS-122006: Warn about ignored install-config fields in ABI

Details

In response to this:

This is an automated cherry-pick of #10646

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-122006, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-91640 to target a version in 5.1.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10646

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zaneb]

/approve
/label backport-risk-assessed
/cherry-pick release-4.22

[openshift-cherrypick-robot]

@zaneb: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/approve
/label backport-risk-assessed
/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/agent/OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.