Skip to content

OCPNODE: cover graceful shutdown KubeletConfig validation - #6478

Draft
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:kubelet-config-gns-validation
Draft

OCPNODE: cover graceful shutdown KubeletConfig validation#6478
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:kubelet-config-gns-validation

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Extends the existing kubelet-config denylist table with all graceful node shutdown fields and their platform-managed feature gates, preserving current hard-rejection behavior. Adds scoped CodeRabbit guidance for kubelet-config changes. No production validation behavior changed. Validation: gofmt and go test ./pkg/controller/kubelet-config; broader make targets were attempted but hit missing gpgme.pc in unrelated builds.


AI-generated. Review for accuracy.

@jaypoulz requested in Slack thread

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant