[release-4.22] OCPBUGS-115401: Update message for MachineOSBuildFailed condition by isabella-janssen · Pull Request #6479 · openshift/machine-config-operator

isabella-janssen · 2026-09-01T19:34:04Z

Closes: OCPBUGS-115401

- What I did
This is a manual backport for #6463. OCL events were added in 5.0 as part of #6252, so event fixes are not necessary for 4.22. However, on MOSB failures, the message was always being set as Build Failed, so this updates the message to be clearer.

- How to verify it

Launch a 4.22 cluster with this PR included.
Enable OCL in a pool with a MachineOSConfig that will cause a MachineOSBuild failure. I do this by setting docker-password to an invalid value in the following flow.

$ oc create secret docker-registry quay-push-secret \
    -n openshift-machine-config-operator \
    --docker-server=quay.io \
    --docker-username=<>
    --docker-password=<>
$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
 name: layered
spec:
 machineConfigSelector:
  matchExpressions:
   - {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,layered]}
 nodeSelector:
  matchLabels:
   node-role.kubernetes.io/layered: ""
EOF
$ oc label node <node> node-role.kubernetes.io/layered=
$ oc apply -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
  name: layered
spec:
  machineConfigPool:
    name: layered
  containerFile:
  - containerfileArch: NoArch
    content: |-
      FROM configs AS final
      RUN dnf install -y nmap && \
        dnf clean all && \
        bootc container lint
  imageBuilder:
    imageBuilderType: Job
  renderedImagePushSecret:
    name: quay-push-secret
  renderedImagePushSpec: "quay.io/<repo-path>:ocl-testing"
EOF

Once the MachineOSBuild fails, check that the Message field for the Failed condition is being set to a clear value.

- Description for the changelog
OCPBUGS-115401: Update message for MachineOSBuildFailed condition

openshift-merge-bot · 2026-09-01T19:34:06Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-09-01T19:34:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-09-01T19:34:14Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e73bfdf1-198a-4da1-a63e-3557fc4cb7c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

isabella-janssen · 2026-09-01T19:34:33Z

/jira cherrypick OCPBUGS-114485

openshift-ci-robot · 2026-09-01T19:35:42Z

@isabella-janssen: Jira Issue OCPBUGS-114485 has been cloned as Jira Issue OCPBUGS-115401. Will retitle bug to link to clone.
/retitle OCPBUGS-115401: Update message for MachineOSBuildFailed condition

Details

In response to this:

/jira cherrypick OCPBUGS-114485

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-09-01T19:35:52Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-115401, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-114485 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-114485 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ptalgulk@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
This is a manual backport for #6463. OCL events were added in 5.0 as part of #6252, so event fixes are not necessary for 4.22. However, on MOSB failures, the message was always being set as Build Failed, so this updates the message to be clearer.

- How to verify it

Launch a 4.22 cluster with this PR included.

Enable OCL in a pool with a MachineOSConfig that will cause a MachineOSBuild failure. I do this by setting docker-password to an invalid value in the following flow.
$ oc create secret docker-registry quay-push-secret \
   -n openshift-machine-config-operator \
   --docker-server=quay.io \
   --docker-username=<>
   --docker-password=<>
$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
name: layered
spec:
machineConfigSelector:
 matchExpressions:
  - {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,layered]}
nodeSelector:
 matchLabels:
  node-role.kubernetes.io/layered: ""
EOF
$ oc label node <node> node-role.kubernetes.io/layered=
$ oc apply -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: layered
spec:
 machineConfigPool:
   name: layered
 containerFile:
 - containerfileArch: NoArch
   content: |-
     FROM configs AS final
     RUN dnf install -y nmap && \
       dnf clean all && \
       bootc container lint
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: quay-push-secret
 renderedImagePushSpec: "quay.io/<repo-path>:ocl-testing"
EOF
Once the MachineOSBuild fails, check that the Message field for the Failed condition is being set to a clear value.

- Description for the changelog
: Update message for MachineOSBuildFailed condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-09-01T21:06:22Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-115401, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-114485 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-114485 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ptalgulk@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-115401

- What I did
This is a manual backport for #6463. OCL events were added in 5.0 as part of #6252, so event fixes are not necessary for 4.22. However, on MOSB failures, the message was always being set as Build Failed, so this updates the message to be clearer.

- How to verify it

Launch a 4.22 cluster with this PR included.

Enable OCL in a pool with a MachineOSConfig that will cause a MachineOSBuild failure. I do this by setting docker-password to an invalid value in the following flow.
$ oc create secret docker-registry quay-push-secret \
   -n openshift-machine-config-operator \
   --docker-server=quay.io \
   --docker-username=<>
   --docker-password=<>
$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
name: layered
spec:
machineConfigSelector:
 matchExpressions:
  - {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,layered]}
nodeSelector:
 matchLabels:
  node-role.kubernetes.io/layered: ""
EOF
$ oc label node <node> node-role.kubernetes.io/layered=
$ oc apply -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: layered
spec:
 machineConfigPool:
   name: layered
 containerFile:
 - containerfileArch: NoArch
   content: |-
     FROM configs AS final
     RUN dnf install -y nmap && \
       dnf clean all && \
       bootc container lint
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: quay-push-secret
 renderedImagePushSpec: "quay.io/<repo-path>:ocl-testing"
EOF
Once the MachineOSBuild fails, check that the Message field for the Failed condition is being set to a clear value.

- Description for the changelog
OCPBUGS-115401: Update message for MachineOSBuildFailed condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

proietfb · 2026-09-02T12:36:19Z

/lgtm

openshift-merge-bot · 2026-09-02T12:36:48Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

openshift-ci · 2026-09-02T12:36:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, proietfb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

proietfb · 2026-09-02T12:37:02Z

/test bootstrap-unit

isabella-janssen · 2026-09-02T12:42:09Z

/verified later @ptalgulk01

openshift-ci-robot · 2026-09-02T12:42:25Z

@isabella-janssen: This PR has been marked to be verified later by @ptalgulk01.

Details

In response to this:

/verified later @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-09-02T14:35:32Z

/retest-required

isabella-janssen · 2026-09-03T12:41:12Z

/cherrypick release-4.21 release-4.20 release-4.19 release-4.18

openshift-cherrypick-robot · 2026-09-03T12:41:15Z

@isabella-janssen: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21 release-4.20 release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

isabella-janssen · 2026-09-03T12:41:19Z

/label backport-risk-assessed

openshift-ci · 2026-09-03T13:10:40Z

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-09-03T13:17:06Z

@isabella-janssen: Jira Issue OCPBUGS-115401: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#6479

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-115401 has been moved to the MODIFIED state.

Details

In response to this:

Closes: OCPBUGS-115401

- What I did
This is a manual backport for #6463. OCL events were added in 5.0 as part of #6252, so event fixes are not necessary for 4.22. However, on MOSB failures, the message was always being set as Build Failed, so this updates the message to be clearer.

- How to verify it

Launch a 4.22 cluster with this PR included.

Enable OCL in a pool with a MachineOSConfig that will cause a MachineOSBuild failure. I do this by setting docker-password to an invalid value in the following flow.
$ oc create secret docker-registry quay-push-secret \
   -n openshift-machine-config-operator \
   --docker-server=quay.io \
   --docker-username=<>
   --docker-password=<>
$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
name: layered
spec:
machineConfigSelector:
 matchExpressions:
  - {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,layered]}
nodeSelector:
 matchLabels:
  node-role.kubernetes.io/layered: ""
EOF
$ oc label node <node> node-role.kubernetes.io/layered=
$ oc apply -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineOSConfig
metadata:
 name: layered
spec:
 machineConfigPool:
   name: layered
 containerFile:
 - containerfileArch: NoArch
   content: |-
     FROM configs AS final
     RUN dnf install -y nmap && \
       dnf clean all && \
       bootc container lint
 imageBuilder:
   imageBuilderType: Job
 renderedImagePushSecret:
   name: quay-push-secret
 renderedImagePushSpec: "quay.io/<repo-path>:ocl-testing"
EOF
Once the MachineOSBuild fails, check that the Message field for the Failed condition is being set to a clear value.

- Description for the changelog
OCPBUGS-115401: Update message for MachineOSBuildFailed condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-09-03T13:17:57Z

@isabella-janssen: new pull request created: #6493

Details

In response to this:

/cherrypick release-4.21 release-4.20 release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-09-04T06:23:05Z

Fix included in release 4.22.0-0.nightly-2026-09-03-194049

controller: update message for MachineOSBuildFailed condition

ac6d66e

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2026

isabella-janssen changed the title ~~controller: update message for MachineOSBuildFailed condition~~ Update message for MachineOSBuildFailed condition Sep 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026

openshift-ci Bot changed the title ~~Update message for MachineOSBuildFailed condition~~ OCPBUGS-115401: Update message for MachineOSBuildFailed condition Sep 1, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 1, 2026

isabella-janssen changed the title ~~OCPBUGS-115401: Update message for MachineOSBuildFailed condition~~ [release-4.22] OCPBUGS-115401: Update message for MachineOSBuildFailed condition Sep 1, 2026

isabella-janssen marked this pull request as ready for review September 1, 2026 21:56

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2026

openshift-ci Bot requested review from RishabhSaini and umohnani8 September 1, 2026 21:57

openshift-ci Bot assigned proietfb Sep 2, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 2, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 3, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, mhanss, ptalgulk01, rbbratta and sergiordlr Sep 3, 2026

openshift-merge-bot Bot merged commit 6ffb4f5 into openshift:release-4.22 Sep 3, 2026
19 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 3, 2026

[release-4.21] OCPBUGS-120453: Update message for MachineOSBuildFailed condition #6493

Open

Uh oh!

Conversation

isabella-janssen commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Sep 1, 2026

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

coderabbitai Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

isabella-janssen commented Sep 1, 2026

Uh oh!

openshift-ci-robot commented Sep 1, 2026

Uh oh!

openshift-ci-robot commented Sep 1, 2026

Uh oh!

openshift-ci-robot commented Sep 1, 2026

Uh oh!

proietfb commented Sep 2, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 2, 2026

Uh oh!

openshift-ci Bot commented Sep 2, 2026

Uh oh!

proietfb commented Sep 2, 2026

Uh oh!

isabella-janssen commented Sep 2, 2026

Uh oh!

openshift-ci-robot commented Sep 2, 2026

Uh oh!

isabella-janssen commented Sep 2, 2026

Uh oh!

isabella-janssen commented Sep 3, 2026

Uh oh!

openshift-cherrypick-robot commented Sep 3, 2026

Uh oh!

isabella-janssen commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 3, 2026

Uh oh!

openshift-cherrypick-robot commented Sep 3, 2026

Uh oh!

openshift-merge-robot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

isabella-janssen commented Sep 1, 2026 •

edited

Loading

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading