[release-4.19] OCPBUGS-120741: [manual cherry-pick of #6446] Use kubernetes scheme in drain controller event recorder

[proietfb]

OCPBUGS-120741: Manual cherry-pick of #6446 for release-4.19: Use kubernetes scheme in drain controller event recorder

- What I did
Use kubernetes scheme in drain controller event recorder

- How to verify it
1- Apply a PodDisruptionBudget that prevent drain:

apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  namespace: openshift-ingress
  name: test
spec:
  maxUnavailable: 0
  selector:
    matchLabels:
      ingresscontroller.operator.openshift.io/deployment-ingresscontroller: default

2- Add a MachineConfig that bumps the worker MachineConfigPool

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  name: 99-worker-drain-test
  labels:
    machineconfiguration.openshift.io/role: worker
spec:
  config:
    ignition:
      version: 3.4.0
    storage:
      files:
        - path: /etc/drain-test-trigger
          mode: 0644
          contents:
            source: data:,drain-test

3 - Logs should not report the following log should not construct reference, will not report event" err="no kind is registered for the type v1.Node in scheme

$ oc logs -n openshift-machine-config-operator -l k8s-app=machine-config-controller -c machine-config-controller -f \
  | grep -E "DrainThresholdExceeded|will not report event"

4 - Check for Events about the failed Node drain

$ oc get events -n default | grep DrainThresholdExceeded # OR all namespaces

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@proietfb: This pull request references Jira Issue OCPBUGS-64623, which is invalid:

• expected the bug to target either version "4.19.z." or "openshift-4.19.z.", but it targets "5.1" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-64623 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-64623: Manual cherry-pick of #6446 for release-4.19: Use kubernetes scheme in drain controller event recorder

Please provide the following information:
-->

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8607310d-554f-4683-9fc7-da47230e0c1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@proietfb: This pull request references Jira Issue OCPBUGS-120741, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-114390 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-114390 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ijanssen@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-64623: Manual cherry-pick of #6446 for release-4.19: Use kubernetes scheme in drain controller event recorder

Please provide the following information:
-->

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@proietfb: This pull request references Jira Issue OCPBUGS-120741, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-114390 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-114390 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ijanssen@redhat.com), skipping review request.

Details

In response to this:

OCPBUGS-120741: Manual cherry-pick of #6446 for release-4.19: Use kubernetes scheme in drain controller event recorder

Please provide the following information:
-->

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[proietfb]

/test unit

[pablintino]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino, proietfb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[proietfb]

/test e2e-hypershift

[openshift-ci]

@proietfb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op	d848c9b	link	true	/test e2e-gcp-op
ci/prow/e2e-hypershift	d848c9b	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.