OCPBUGS-104452: Fix TLS ciphers for MinVersion=1.3

[oribon]

Summary by CodeRabbit

• Bug Fixes
  • TLS 1.3 configurations that specify cipher suites are now accepted.
  • Configured cipher suites are preserved without triggering a validation error.

[openshift-ci-robot]

@oribon: This pull request references Jira Issue OCPBUGS-104452, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d6ab8126-a34b-4eaa-bcb3-9aa1f9f2236c

📥 Commits

Reviewing files that changed from the base of the PR and between 3abd6ea and a630d63.

📒 Files selected for processing (2)

• pkg/tlsconfig/tlsopt.go
• pkg/tlsconfig/tlsopt_test.go

💤 Files with no reviewable changes (1)

• pkg/tlsconfig/tlsopt.go

---

Walkthrough

OptFor no longer rejects cipher suites when the minimum TLS version is TLS 1.3. The test now verifies successful configuration and preservation of the cipher suite.

Changes

TLS 1.3 cipher suite handling

Layer / File(s)	Summary
Allow TLS 1.3 cipher suites pkg/tlsconfig/tlsopt.go, pkg/tlsconfig/tlsopt_test.go	OptFor removes the TLS 1.3 cipher-suite validation error and its documentation. TestOptFor expects the cipher suite and TLS 1.3 minimum version to be applied.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: fedepaol, gclawes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description and omits all required template sections, including the change summary, reviewer notes, and release note.	Add the required sections, describe the TLS cipher fix, identify the change as a bug fix, and provide a release note or NONE.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the TLS cipher handling fix for configurations with MinVersion=1.3.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request modifies pkg/tlsconfig/tlsopt_test.go, which uses Go's standard testing framework (t *testing.T), not Ginkgo. The custom check applies only to Ginkgo tests. This check is not appli...
Test Structure And Quality	✅ Passed	The changed test is table-driven standard Go testing, not Ginkgo; it uses no cluster resources or waits, and its assertions provide diagnostic messages consistent with nearby unit tests.
Microshift Test Compatibility	✅ Passed	The PR changes only pkg/tlsconfig Go code and a standard TestOptFor unit test; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only tlsopt.go and a standard Go testing.TestOptFor unit test; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch changes only TLS option parsing and tests; it adds no deployments, controllers, manifests, replicas, affinity, topology spread, node selectors, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only TLS parsing and its unit test; neither changed file adds process-level stdout writes, logging setup, or OTE suite entry-point code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only a tlsconfig implementation and a Go testing.T unit test; it adds no Ginkgo e2e test, IPv4 assumption, or external connectivity.
No-Weak-Crypto	✅ Passed	The diff adds only AES-128-GCM-SHA256 test coverage and removes TLS 1.3 rejection; it adds no weak algorithms, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The patch changes only Go source and tests; no container or Kubernetes manifests, privilege settings, host namespaces, SYS_ADMIN, or root execution were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only TLS option validation and tests; it adds no logging or sensitive-data output. Existing TLS logs contain cipher names and minimum version only.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oribon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [oribon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@oribon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[oribon]

/verified later @ajaggapa

[openshift-ci-robot]

@oribon: This PR has been marked to be verified later by @ajaggapa.

Details

In response to this:

/verified later @ajaggapa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fedepaol]

/lgtm

[openshift-ci-robot]

@oribon: Jira Issue OCPBUGS-104452: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/frr#135 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-104452 has not been moved to the MODIFIED state.

This PR is marked as verified-later. Jira issue(s) in the title of this PR will require post-merge verification. After testing, it must be manually moved to the VERIFIED state.

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes
• TLS 1.3 configurations that specify cipher suites are now accepted.
• Configured cipher suites are preserved without triggering a validation error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.