oadp-operator: split e2e-test-kubevirt-aws-periodic into kdm/non-kdm jobs by kaovilai · Pull Request #84592 · openshift/release

kaovilai · 2026-09-04T00:30:39Z

Summary

Same split already applied to the presubmits (#84337, #84490), now extended to the daily periodics that were deliberately left unsplit at the time. All branches now have TEST_VIRT_KDM support (openshift/oadp-operator#2423, openshift/oadp-operator#2424), so the periodics are safe to split too:

virt-nokdm-e2e-test-aws-periodic: make TEST_VIRT=true TEST_VIRT_KDM=false test-e2e
virt-kdm-e2e-test-aws-periodic: make TEST_VIRT_KDM=true test-e2e

Applied to all 5 variant configs that carry this periodic: oadp-dev (5.0, 5.1) and oadp-1.6 (4.22, 4.23, 5.0). Both split jobs keep the same cron schedule and Slack reporter_config as the job they replace.

Held in draft until rehearsals actually complete (prior two PRs in this series both merged before their e2e rehearsals finished — tide's fast merge outran the ~40min+ e2e jobs).

Note

Responses generated with Claude

Summary by CodeRabbit

Updates OpenShift CI periodic KubeVirt AWS tests for the OADP operator.

Splits the existing periodic job into separate non-KDM and KDM jobs across five OADP/OpenShift variants.
Runs non-KDM tests with TEST_VIRT=true TEST_VIRT_KDM=false.
Runs KDM tests with TEST_VIRT_KDM=true.
Preserves the existing cron schedules and Slack reporter_config.

…jobs Same split already applied to the presubmits (openshift#84337, openshift#84490), now extended to the daily periodics we'd deliberately left unsplit at the time. All branches now have TEST_VIRT_KDM support (openshift/oadp-operator#2423, openshift#2424), so the periodics are safe to split too: - virt-nokdm-e2e-test-aws-periodic: TEST_VIRT=true TEST_VIRT_KDM=false - virt-kdm-e2e-test-aws-periodic: TEST_VIRT_KDM=true Applied to all 5 variant configs that carry this periodic: oadp-dev (5.0, 5.1) and oadp-1.6 (4.22, 4.23, 5.0). Both split jobs keep the same cron schedule and Slack reporter_config as the job they replace. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

kaovilai · 2026-09-04T00:31:00Z

/pj-rehearse periodic-ci-openshift-oadp-operator-oadp-1.6-4.22-virt-kdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-1.6-4.22-virt-nokdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-1.6-4.23-virt-kdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-1.6-4.23-virt-nokdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-1.6-5.0-virt-kdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-1.6-5.0-virt-nokdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-dev-5.0-virt-kdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-dev-5.0-virt-nokdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-dev-5.1-virt-kdm-e2e-test-aws-periodic periodic-ci-openshift-oadp-operator-oadp-dev-5.1-virt-nokdm-e2e-test-aws-periodic

Note

Responses generated with Claude

openshift-merge-bot · 2026-09-04T00:31:03Z

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-09-04T00:31:14Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-09-04T00:31:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 47412b9c-9f03-4e7d-acac-044984d12e58

📥 Commits

Reviewing files that changed from the base of the PR and between c2f1ae6 and f031cbf.

⛔ Files ignored due to path filters (2)

ci-operator/jobs/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6-periodics.yaml is excluded by !ci-operator/jobs/**
ci-operator/jobs/openshift/oadp-operator/openshift-oadp-operator-oadp-dev-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.22.yaml
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__4.23.yaml
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.6__5.0.yaml
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.1.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The periodic AWS KubeVirt test is split into non-KDM and KDM jobs across five OADP release configurations. Each job has a distinct name, test name, and DataMover setting.

Changes

KubeVirt periodic test modes

Layer / File(s)	Summary
Non-KDM periodic job `ci-operator/config/openshift/oadp-operator/*`	The existing periodic KubeVirt AWS job is renamed to `virt-nokdm-e2e-test-aws-periodic` and explicitly runs with `TEST_VIRT=true TEST_VIRT_KDM=false`.
KDM periodic job `ci-operator/config/openshift/oadp-operator/*`	A separate `virt-kdm-e2e-test-aws-periodic` job is added with `TEST_VIRT_KDM=true` and matching AWS periodic-test wiring.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f031c

The periodic KubeVirt AWS coverage is split into explicit KDM and non-KDM jobs across the configured release variants, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The PR changes only YAML CI configurations and generated periodic job definitions. It adds no Ginkgo `It`, `Describe`, `Context`, or `When` titles. The new `TEST_NAME` and job names use fixed st…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only seven `.yaml` CI configuration/generated job files. The diff contains no Ginkgo test code or changes to `It`, `BeforeEach`, `AfterEach`, `Eventually`, `Consistently…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only seven `.yaml` CI configuration files. The diff adds or updates periodic job definitions and `make ... test-e2e` commands; it adds no Ginkgo test declarations or tes…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only seven YAML CI configuration/generated-job files. The diff adds no Go files and no new Ginkgo declarations (`It`, `Describe`, `Context`, or `When`). It only splits e…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request changes only five `ci-operator/config/...` test definitions and two generated `ci-operator/jobs/...-periodics.yaml` files. The changes split periodic commands and rename CI job…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only seven YAML CI configuration/generated job files. The diff contains no Go or OTE binary source and no process-level stdout or logging writes. The changed `make` comm…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The PR adds no Ginkgo test code. The diff changes five CI test declarations and two generated periodic-job YAML files. The new commands only select existing test modes: `make TEST_VIRT=true TES…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only OADP periodic YAML declarations and generated job YAML. The new commands set `TEST_VIRT` and `TEST_VIRT_KDM`; they do not add MD5, SHA1, DES, 3DES, RC4, Blowfish, o…
Container-Privileges	✅ Passed	PASS: The pull request changes only CI job names, TEST_NAME values, test commands, and duplicated schedule/reporting/step fields in five YAML CI configurations. The committed diff adds no `privileged`…
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds CI job metadata only. The new commands set `TEST_VIRT` and `TEST_VIRT_KDM`; they do not print credentials or sensitive values. Credential mounts reference existing secret names and paths, …
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: splitting the periodic KubeVirt AWS test into separate KDM and non-KDM jobs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-09-04T00:34:03Z

[REHEARSALNOTIFIER]
@kaovilai: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-oadp-operator-oadp-dev-5.0-virt-nokdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-5.0-virt-kdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-dev-5.1-virt-nokdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-dev-5.1-virt-kdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-4.23-virt-kdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-4.22-virt-kdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-dev-5.0-virt-kdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-4.22-virt-nokdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-4.23-virt-nokdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed
periodic-ci-openshift-oadp-operator-oadp-1.6-5.0-virt-nokdm-e2e-test-aws-periodic	N/A	periodic	Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

kaovilai · 2026-09-04T03:09:52Z

All 10 periodic rehearsals passed cleanly. Marking ready for review.

Note

Responses generated with Claude

kaovilai · 2026-09-04T03:10:14Z

Correction: the oadp-1.6-5.0-virt-kdm link in my previous comment was wrong (accidental duplicate of the oadp-dev-5.0-virt-kdm build ID). Correct one:

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/84592/rehearse-84592-periodic-ci-openshift-oadp-operator-oadp-1.6-5.0-virt-kdm-e2e-test-aws-periodic/2095671798174584832

Also passed. All 10/10 confirmed.

Note

Responses generated with Claude

openshift-ci · 2026-09-04T03:20:08Z

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2026-09-04T14:13:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/oadp-operator/OWNERS~~ [kaovilai,sseago]
~~ci-operator/jobs/openshift/oadp-operator/OWNERS~~ [kaovilai,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kaovilai · 2026-09-04T14:31:08Z

/pj-rehearse ack

openshift-merge-bot · 2026-09-04T14:34:30Z

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2026

kaovilai marked this pull request as ready for review September 4, 2026 03:09

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026

openshift-ci Bot requested review from mpryc and shubham-pampattiwar September 4, 2026 03:10

sseago approved these changes Sep 4, 2026

View reviewed changes

openshift-ci Bot assigned sseago Sep 4, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2026

openshift-merge-bot Bot merged commit 954ae59 into openshift:main Sep 4, 2026
26 checks passed

Navigation Menu

Uh oh!

oadp-operator: split e2e-test-kubevirt-aws-periodic into kdm/non-kdm jobs - #84592

oadp-operator: split e2e-test-kubevirt-aws-periodic into kdm/non-kdm jobs#84592
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
kaovilai:worktree-oadp-split-periodic-kubevirt

kaovilai commented Sep 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

coderabbitai Bot commented Sep 4, 2026 •

edited

Loading

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kaovilai commented Sep 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

coderabbitai Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

kaovilai commented Sep 4, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kaovilai commented Sep 4, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 4, 2026 •

edited

Loading