Skip to content

Add tests/Testing.cpp and create osimTesting target - #4455

Merged
adamkewley merged 1 commit into
mainfrom
test_helpers_updates_part1
Sep 23, 2026
Merged

adamkewley merged 1 commit into
mainfrom
test_helpers_updates_part1

Conversation

@nickbianco

@nickbianco nickbianco commented Sep 18, 2026

Copy link
Copy Markdown
Member

Part 1 of 4 changes related to #3555 and #4393.

These changes were originally written all together on a different branch that was supposed to only add Testing.cpp and some minor changes, but eventually ballooned as I started to pull on threads. Therefore, I used Claude to split the changes on the branch onto four different branches and created a stack of PRs , a new feature offered by the GitHub CLI (e.g., gh stack) that I wanted to try out.

Brief summary of changes

  • Moves all non-macro test helpers in Testing.h inside the new OpenSim::Testing namespace (except for CHECK_STORAGE_AGAINST_STANDARD which gets converted in part 2).
  • Moves the implementation of all (non-templatized) test helpers to the new file Testing.cpp.
  • Packages the test helper functions and macros into the new build target osimTesting.

Testing I've completed

Ran tests locally; CI.

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...updating internal test layout.

Stack created with GitHub Stacks CLIGive Feedback 💬


This change is Reviewable

@nickbianco
nickbianco added this pull request to stack #4459 September 18, 2026 21:08
@nickbianco
nickbianco force-pushed the test_helpers_updates_part1 branch from 9371113 to bf9b8a2 Compare September 18, 2026 22:14
@nickbianco nickbianco changed the title Reorganize tests/Testing.h and add tests/Testing.cpp Reorganize tests/Testing.h and add tests/Testing.cpp Sep 21, 2026
@nickbianco
nickbianco force-pushed the test_helpers_updates_part1 branch 2 times, most recently from 3817d9c to 1871ad4 Compare September 21, 2026 14:47
@nickbianco
nickbianco marked this pull request as ready for review September 21, 2026 14:47
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@nickbianco
nickbianco force-pushed the test_helpers_updates_part1 branch from 1871ad4 to e4ddd99 Compare September 21, 2026 14:51
@nickbianco nickbianco changed the title Reorganize tests/Testing.h and add tests/Testing.cpp Add tests/Testing.cpp and create osimTesting target Sep 21, 2026
@adamkewley

Copy link
Copy Markdown
Contributor

@nickbianco looks like a sensible cleanup 👍

@adamkewley
adamkewley merged commit 3d1973d into main Sep 23, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants