Convert CHECK_STORAGE_AGAINST_STANDARD to a macro - #4456
Merged
Merged
Conversation
nickbianco
added this pull request to stack #4459
September 18, 2026 21:08
nickbianco
force-pushed
the
test_helpers_updates_part2
branch
2 times, most recently
from
September 21, 2026 14:30
980921f to
69b5104
Compare
nickbianco
force-pushed
the
test_helpers_updates_part2
branch
2 times, most recently
from
September 21, 2026 14:51
34661d1 to
66243b7
Compare
nickbianco
force-pushed
the
test_helpers_updates_part2
branch
4 times, most recently
from
September 21, 2026 16:01
43b2b09 to
ff1d755
Compare
nickbianco
changed the title
nickbianco
changed the title
CHECK_STORAGE_AGAINST_STANDARD to a macro
nickbianco
force-pushed
the
test_helpers_updates_part2
branch
from
September 21, 2026 16:07
ff1d755 to
4f36e51
Compare
nickbianco
marked this pull request as ready for review
September 21, 2026 16:07
nickbianco
force-pushed
the
test_helpers_updates_part2
branch
2 times, most recently
from
September 21, 2026 18:45
ba7bc2a to
1e521f6
Compare
…redicate Reimplement the storage comparison as OpenSim::Testing::storageMatchesStandard(), a bool-returning predicate defined in Testing.cpp, and keep CHECK_STORAGE_AGAINST_STANDARD as a thin variadic macro that wraps it in OPENSIM_ASSERT_ALWAYS. Expanding the assertion at the call site makes a failure report the test's file and line rather than a location inside Testing.cpp, which matters because the helper has ~60 call sites. The per-column RMS errors and tolerances are still written to stdout, and the offending column is now named explicitly on failure. Call sites drop the file/line/message arguments; the macro spelling is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
adamkewley
force-pushed
the
test_helpers_updates_part2
branch
from
September 23, 2026 05:30
1e521f6 to
3b1e4d0
Compare
adamkewley
approved these changes
Sep 23, 2026
adamkewley
left a comment
adamkewley
left a comment
Contributor
There was a problem hiding this comment.
@adamkewley reviewed 31 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nickbianco).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 4 changes related to #3555 and #4393.
These changes were originally written all together on a different branch that was supposed to only add
Testing.cppand some minor changes, but eventually ballooned as I started to pull on threads. Therefore, I used Claude to split the changes on the branch onto four different branches and created a stack of PRs , a new feature offered by the GitHub CLI (e.g.,gh stack) that I wanted to try out.Brief summary of changes
Converts
CHECK_STORAGE_AGAINST_STANDARDto a macro backed by the newOpenSim::Testing::storageMatchesStandard(). The error message argument has been removed since the majority of usages were not very informative and/or are redundant with the test context that Catch2 provides.Testing I've completed
Ran tests locally; CI.
Looking for feedback on...
CHANGELOG.md (choose one)
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is