One-time configure() for notification text - #31
Merged
Conversation
This was referenced Aug 24, 2026
dmurphy5
marked this pull request as ready for review
August 25, 2026 17:21
dmurphy5
changed the title
dmurphy5
force-pushed
the
dylan/v9-3-configure
branch
from
August 25, 2026 17:35
005ce21 to
30f6636
Compare
dmurphy5
marked this pull request as draft
August 25, 2026 17:38
dmurphy5
marked this pull request as ready for review
August 27, 2026 18:33
Notification text and identity are library-wide, not per-upload. The new configure() persists them natively (SharedPreferences) so a worker relaunched by WorkManager with no JS running builds the notification with the configured text; the library defaults apply when configure() was never called. Per-upload android options reduce to noNotification, which is behavioral — it decides foreground-service survival. configure() is a native no-op on iOS, which has no library notification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dmurphy5
force-pushed
the
dylan/v9-3-configure
branch
from
August 28, 2026 16:49
30f6636 to
b89c473
Compare
elliottkember
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diana builds the same notification text object for each
startUploadcall. This PR moves that text to a one-timeconfigure()call.The library writes the configuration to SharedPreferences. Thus a worker that WorkManager relaunches with no JS running builds its notification with the same text. If the app never calls
configure(), the library uses its default text. The per-uploadandroidoptions decrease to one flag:noNotification.A
TODOin Diana'sbackgroundUploadUtils.tssuggested this change.Built and reviewed with a multi-agent workflow: a six-dimension adversarial review. Every confirmed finding was fixed inside its slice.
🤖 Generated with Claude Code