fix(eso): remove targetNamespaces from OperatorGroup spec#91
Merged
Conversation
Remove the explicit `targetNamespaces: []` from the
openshift-external-secrets-operator OperatorGroup and leave the spec
empty (`spec: {}`).
An OperatorGroup with `targetNamespaces: []` and one with an empty
spec both configure AllNamespaces install mode — they are semantically
identical. However, OLM normalizes the OperatorGroup on every
reconciliation cycle: it strips `targetNamespaces: []` from the spec
entirely and replaces it with `{"upgradeStrategy": "Default"}`.
This creates permanent drift in the operator-dependencies ArgoCD
application:
- ArgoCD applies the manifest with `targetNamespaces: []`
- OLM reconciles and removes the field
- ArgoCD detects the diff (`> targetNamespaces: []` present in
desired but absent in live) and marks the resource OutOfSync
- Auto-sync re-applies, OLM re-normalizes, and the cycle repeats
By omitting the field from the source manifest, the desired state
matches what OLM produces after normalization, eliminating the
persistent OutOfSync condition.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cjeanner
force-pushed
the
fix/remove-eso-operatorgroup-targetns
branch
from
July 22, 2026 11:03
519a65f to
3a33327
Compare
cjeanner
marked this pull request as ready for review
July 22, 2026 13:22
cjeanner
enabled auto-merge (squash)
July 22, 2026 13:32
pinikomarov
approved these changes
Jul 23, 2026
pinikomarov
left a comment
pinikomarov
left a comment
Collaborator
There was a problem hiding this comment.
logic is reasonable , lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the explicit
targetNamespaces: []from theopenshift-external-secrets-operator OperatorGroup and leave the spec
empty (
spec: {}).An OperatorGroup with
targetNamespaces: []and one with an emptyspec both configure AllNamespaces install mode — they are semantically
identical. However, OLM normalizes the OperatorGroup on every
reconciliation cycle: it strips
targetNamespaces: []from the specentirely and replaces it with
{"upgradeStrategy": "Default"}.This creates permanent drift in the operator-dependencies ArgoCD
application:
targetNamespaces: []> targetNamespaces: []present indesired but absent in live) and marks the resource OutOfSync
By omitting the field from the source manifest, the desired state
matches what OLM produces after normalization, eliminating the
persistent OutOfSync condition.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com