make escape close navigation on narrow screen - #3093
Open
Alex-Jordan wants to merge 1 commit into
Open
Conversation
drgrice1
reviewed
Jul 26, 2026
drgrice1
reviewed
Jul 27, 2026
drgrice1
left a comment
Member
There was a problem hiding this comment.
I just noticed something else that will probably need to be made inert while the sidebar is open on a narrow screen. That is the "Skip to main content" link. I noticed that if the sidebar is open, that link is still in the tab order, and if you focus it with the keyboard and hit enter it still attempts to focus the page content, and then things get weird with the tab order.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
OK, I made some changes here that I think address your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a narrow screen, when the sidebar navigation is open, this change makes it so that the escape key closes the navigation.
From Claude:
This was all a "medium" accessibility issue that Claude found.