make a few anchors with 'role="button"' respond to space - #3096
Open
Alex-Jordan wants to merge 1 commit into
Open
make a few anchors with 'role="button"' respond to space#3096Alex-Jordan wants to merge 1 commit into
Alex-Jordan wants to merge 1 commit into
Conversation
Contributor
Author
|
This was the last item Claude found for accessibility concerns with webwork2. The only unaddressed item after all these PRs is the one about PDF harcopies not being tagged. |
drgrice1
reviewed
Jul 27, 2026
Alex-Jordan
force-pushed
the
button-space
branch
2 times, most recently
from
July 27, 2026 02:03
6515df4 to
a54cc71
Compare
drgrice1
reviewed
Jul 27, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
As I am saying with all of these JavaScript changes, please change the forEach usage to for of loops.
Then this pull request is good.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Alex-Jordan
force-pushed
the
button-space
branch
from
July 27, 2026 17:50
a54cc71 to
4578b53
Compare
Contributor
Author
|
OK, they are now "for of" loops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.