Skip to content

show links to sets even when you are not assigned to those sets - #3097

Open
Alex-Jordan wants to merge 1 commit into
openwebwork:WeBWorK-2.21from
Alex-Jordan:set-links
Open

show links to sets even when you are not assigned to those sets#3097
Alex-Jordan wants to merge 1 commit into
openwebwork:WeBWorK-2.21from
Alex-Jordan:set-links

Conversation

@Alex-Jordan

Copy link
Copy Markdown
Contributor

Suppose you are an instructor and there is a set that is not assigned to you. If you go to the Sets Manager, and go to the Set Details page for that set, you won't see links to that set in the side navigation (under Sets Manager, Statistics, and Student Progress). This changes it so that you do. For example, it facilitates going to the Statistics page for that set even though it's not assigned to you as a user.

@drgrice1

Copy link
Copy Markdown
Member

I think that a little more granularity is needed for which links specifically are shown. If an instructor is not assigned to the set, then I agree with showing the sub links for Sets Manager, Statistics and Student Progress, but I don't think that the sub link for Assignments should be shown. That just leads to a useless page with an error alert showing that the set is not valid for the user.

Either that or this should be taken further. Currently as noted above if the instructor is not assigned to a set, you get the error alert that the set is not valid. That should perhaps still be shown, but lets assume that the set is assigned to students. If the student navigation were still shown when the instructor goes to this page, then this page still is useful. Although, that would take some work to implement since it would probably involve needing to make changes to the WeBWorK::checkSet method.

@Alex-Jordan

Copy link
Copy Markdown
Contributor Author

I pushed changes so that the link is not shown under Assignments (if you are not actually assigned to the set).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants