docs: let the page use the full viewport width - #1231
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and low-risk, with only a minor doc-comment clarity issue noted.
Pull request overview
Adjusts the Sphinx docs theme configuration so OpenWPM’s documentation uses the full viewport width, avoiding Alabaster’s default centered fixed-width layout that squeezes wide content (e.g., large tables).
Changes:
- Add
html_theme_optionsfor the Alabaster theme to setpage_widthto100%. - Set a fixed
sidebar_widthto keep the navigation consistent while letting the body expand.
File summaries
| File | Description |
|---|---|
| docs/conf.py | Configures Alabaster theme options to use full-width pages with a fixed-width sidebar. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+71
to
+74
| # Alabaster centres a fixed 940px page, which leaves the sidebar floating | ||
| # mid-screen and wraps wide tables (e.g. the requirements matrix in | ||
| # developers/Stealth-Requirements.rst) into a narrow column. Use the whole | ||
| # viewport: the sidebar sits flush left and the body takes the rest. |
vringar
force-pushed
the
docs/full-width-layout
branch
from
September 6, 2026 16:15
13b1f10 to
6c11e3f
Compare
vringar
enabled auto-merge
September 6, 2026 16:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 40 40
Lines 3930 3930
=======================================
Hits 2449 2449
Misses 1481 1481 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 6, 2026
Alabaster centres a fixed 940px page by default, which leaves the navigation sidebar floating in the middle of the screen and squeezes wide content into a narrow column. The requirements matrix in developers/Stealth-Requirements.rst is the worst case: a wide table wrapped into roughly a third of a modern display. Span the viewport instead, so the sidebar sits flush against the left edge and the body gets every remaining pixel.
vringar
force-pushed
the
docs/full-width-layout
branch
from
September 6, 2026 20:23
6c11e3f to
6e0f811
Compare
vringar
enabled auto-merge
September 6, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alabaster centres a fixed 940px page by default, so the navigation sidebar floats in the middle of the screen and wide content is squeezed into a narrow column. The requirements matrix in
developers/Stealth-Requirements.rstis the worst case — a wide table wrapped into roughly a third of a modern display.page_widthandsidebar_widthare alabaster's own options, confirmed against the installed theme'stheme.conf. There was nohtml_theme_optionsblock at all before this, so the theme was running entirely on defaults.The sidebar ends up flush against the left edge and the body takes the remaining width.
One caveat on reviewing this: the effect is most visible on pages that #1154 adds, so the Read the Docs preview for this PR shows the change against the current docs only.