[op-18418] Sign up errors are showing behind new account creation modal#24306
[op-18418] Sign up errors are showing behind new account creation modal#24306bsatarnejad wants to merge 12 commits into
Conversation
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
HDinger
left a comment
There was a problem hiding this comment.
This might work, but feels somehow cumbersome to remember the error by hand and then render it in the modal. Further, it will be obsolete as soon as we migrate the page to Primer.. Maybe I am missing something here, but I see no reason that this needs to be in Angular. Also, I don't think that this have to be a dialog.
Imho, it would be best to migrate the form to a primer form, get rid of the dialog and just render the form. We can still center the form if desired.
65e3882 to
86f4697
Compare
registration modal instead of using the page-level flash area.
83fca9f to
f621a0b
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
Ticket
https://community.openproject.org/wp/OP-18418
Screenshots
What approach did you choose and why?