Repository navigation
feat(notification): include picture galleries in the HTTP webhook - #489
Merged
Merged
Conversation
Providers now pass on the pictures they already fetch as `images` (floor plans first, at most 20), and the HTTP adapter sends them next to `imageUrl`. Detail page: ImmoScout24, Kleinanzeigen. Search result: Immowelt, SeLoger, Deutsche Wohnen, immobilien.de, Engel & Völkers. No extra requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an optional
images: [{url, caption?, floorPlan?}]field to the HTTP webhook, built only from responses Fredy already loads:No additional requests.
imageUrlis unchanged, and the field is omitted when there is no gallery. Floor plans come first, capped at 20.Related issue
#344: as mentioned there, opening each listing can be enabled in the settings (provider details), but even then the pictures in those responses are dropped. This PR passes them on for webhook consumers.
Going further, these pictures could also be stored and shown in Fredy itself (database, listing view). I'll open a separate issue for that.
AI disclosure (required)
ai:none- I wrote this myself. No AI generated code, text or commit messages.ai:assisted- AI helped with parts of it (autocomplete, refactoring, tests, docs). I reviewed and understand every line.ai:generated- AI produced most or all of this PR. I reviewed it, but it is largely machine written.Which AI: Claude Code (Claude Opus 5.5)
How much: Most of the code and tests; I defined the approach, reviewed the diff and trimmed it down.
Why: Faster to cover the different gallery formats of several providers.
Checklist
yarn test:offlinepasses (oryarn testif the change touches a live provider)yarn lintandyarn format:checkpass