Repository navigation
fix(sparkasse): update selectors for the redesigned search results page - #495
Merged
orangecoding merged 2 commits intoOct 28, 2026
Merged
orangecoding merged 2 commits into
orangecoding merged 2 commits into
Conversation
The cards no longer carry data-id="estate-list-item" or the .estate-* classes, so the crawl container matched nothing. Cards are now data-testid="estate-teaser"; read title, price, address from their testids and size/rooms from the main-facts block by label (each fact is optional). Re-record the search fixture with the new markup and add a test that every card yields its fields.
orangecoding
requested changes
Oct 28, 2026
| * Licensed under Apache-2.0 with Commons Clause and Attribution/Naming Clause | ||
| */ | ||
|
|
||
| import { describe, it, expect } from 'vitest'; |
Owner
There was a problem hiding this comment.
why did you write a new test and did not update the existing one sparkasse.test.js?
Contributor
Author
There was a problem hiding this comment.
Good point, there was no reason for a separate file. I moved the card assertions into sparkasse.test.js as an additional it and removed sparkasseSearchCards.test.js. It parses the recorded fixture offline, so the selectors are checked on every run even when the live portal isn't reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Sparkasse search page was redesigned: cards no longer carry
data-id="estate-list-item"or the.estate-*classes, so the provider logsNo elements in crawl container foundand returns nothing (broken on my instance since 2026-10-20, still broken on 30.1.1 andmaster). Cards are now[data-testid="estate-teaser"]. This moves the container and the title/price/address selectors to the new testids and reads size and rooms from the main-facts block by label, since each fact is optional.Also re-records the search fixture and adds a test that every card yields its fields.
Related issue
none
AI disclosure (required)
ai:assisted- AI helped with parts of it (autocomplete, refactoring, tests, docs). I reviewed and understand every line.Which AI: Claude Code, Sonnet 5.5
How much: the selector change, the fixture re-recording and the new test were drafted with Claude Code; I reviewed every line and ran the checks.
Why: the site redesign broke Sparkasse on my instance and I wanted the fix upstream.
Checklist
yarn test:offlinepasses (the live tests were not run)yarn lintandyarn format:checkpass