refactor(component-ownership): relocate misplaced shared components - #1000
Merged
Conversation
Pre-commit hook ran. Total eslint: 0, total circular: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App-root services, engine-owned terminal/session UI, domain-specific tables and hover cards, and reusable primitives had accumulated under generic component/shared roots. That obscured ownership, encouraged broad forwarding barrels, and made import direction difficult to reason about. The terminal relocation also exposed two concrete hazards: stale relative Sass paths and a reverse TerminalCore-to-SessionCore composition dependency.
Solution
Potential risks
The primary risk is import-path churn across a large internal surface: downstream branches or untracked local code that still imports the retired paths will need to update. Terminal chunking, CSS resolution, theme repainting, and read-only composition are the highest runtime-risk areas; targeted tests and a production webpack build cover them. No dependency, lockfile, persistence, schema, IPC, wire-format, or public package API changes are included. Rollback is a single-commit revert.
No screenshots were captured because this is an ownership/import refactor with no intended visual change; screenshots would not distinguish the result. A desktop GUI smoke test was not run because Computer Use was not authorized.
Verification
The focused frontend consistency review was applied manually because the documented frontend-ui-audit skill is unavailable in this workspace. No new design-system, accessibility, arbitrary-value, or visual-pattern concerns were found.