refactor(conversation): centralize execution registry - #943
Closed
Neonforge98 wants to merge 1 commit into
Closed
Conversation
Move hidden runner persistence behind one per-conversation store keyed by cloud identity, organization, and root session. Preserve legacy runner visibility filtering, record terminal lifecycle, and remove localStorage ownership from the turn runner.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shared-conversation one-shot runners persist their hidden-session registry directly inside
conversationTurnRunneras one global localStorage blob keyed with colon-concatenated organization and session ids. That couples execution to sidebar policy, permits key collisions, can lose an unrelated conversation update from another desktop window, and does not isolate records across cloud accounts.Solution
(executor scope, root session)tuple.conversationRunnerSessionsfacade.Potential risks
Validation
pnpm typecheck