chore(packages): remove unused packages/ workspace stubs - #992
Merged
Conversation
`packages/` was never wired up: pnpm-workspace.yaml declares `packages: ["."]`, so none of the three packages were installed workspace members, and nothing in the repo imported them. - `@orgii/ui` held one duplicate of the chat font scale. The live implementation is src/styles/_chat-typography.scss plus the `--chat-font-size` write in src/app/root/useAppShellEffects.ts. Commit 0cf7cbb edited both copies in lockstep, so the unreachable one was still costing review time on every change. - `@orgii/marketplace` and `@orgii/orgii-core` were empty skeletons (.gitkeep only) for an OSS/commercial split that was never built, and packages/README.md pointed at docs/rust-backend/oss-boundary--0506.md, which does not exist in this repository. Also drops the now-dangling references: the `packages/` prefix in the CI Rust-skip allowlist (a directory that no longer exists, and one that previously covered a packages/*/src-tauri path — so keeping it would have been a latent way to skip Rust CI), its test fixture, the dependabot exclusion note, and the wiki's pointer to packages/orgii_core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/has never been wired into the build.pnpm-workspace.yamldeclares
packages: ["."], so none of its three packages were installedworkspace members, and a repo-wide search finds zero imports of
@orgii/ui,@orgii/marketplace, or@orgii/orgii-core— the onlyoccurrence of any of those names is in the packages' own
package.jsonfiles.
The cost is not just dead weight:
@orgii/uiwas being maintained despite being unreachable. It helda duplicate of the chat font scale. The live implementation is
src/styles/_chat-typography.scss(which defines.chat-text,.chat-text-xs,.chat-code-sm) plus the--chat-font-sizewrite insrc/app/root/useAppShellEffects.ts:152. Commit0cf7cbbb("style(chat): tighten chat pane font size scale") edited both
copies in lockstep — so every font-scale change was paying a tax on a
file that does not participate in the build, and a future divergence
between the two copies would have been invisible.
@orgii/marketplaceand@orgii/orgii-corewere empty skeletons(
.gitkeepfiles only) for an OSS/commercial package split that wasnever built.
packages/README.mddescribed that plan as in progressand pointed at
docs/rust-backend/oss-boundary--0506.md, which doesnot exist in this repository. Anyone following that README would have
been working from a plan the repo had already abandoned.
Solution
Delete
packages/in full, along with every reference that only existedto serve it:
scripts/ci/detect-rust-changes.cjs— drop thepackages/prefix fromFRONTEND_ONLY_PREFIXES. Beyond pointing at a directory that no longerexists, the deleted skeletons contained
packages/*/src-tauri/paths,so had that layout ever been filled in, this entry would have silently
skipped Rust CI for Rust changes. Removing it fails safe: a future
packages/would now trigger Rust CI unnecessarily rather than skip itwrongly.
scripts/ci/detect-rust-changes.test.cjs— drop the correspondingpackages/ui/src/styles.scssfixture line..github/dependabot.yml— drop the "not covered here, deliberately"note about
packages/*.docs/contributing/wiki/Architecture-Overview.md— the AGPL-3.0rationale row pointed at
packages/orgii_coreas a planned OSS core.Reworded to state the licensing rationale without the dangling
reference. Prettier reflowed that table's column widths as a
consequence of the longer cell; no other row changed in content.
No
src/orsrc-tauri/file is touched.Potential risks
Low, and the failure mode would be a build error rather than silent
breakage.
tree (excluding
node_modules,.git,target) for@orgii/ui,@orgii/marketplace,@orgii/orgii-core,ChatFontStyles,packages/ui, andpackages/orgii— after this change there are zerohits.
--chat-font-sizevariable are defined and consumed entirely withinsrc/; the deleted copy was never loaded.With
packages/gone, no diff can start with that prefix today. Thechange matters only if the directory returns, and then in the
conservative direction.
packages/later is unaffected. It was never aworkspace member, so a future package (for example a shared market
client) starts from the same position it would have started from
before this PR:
pnpm-workspace.yamlneedspackages/*added.Verification
Commands run in a clean worktree off
develop:node --test scripts/ci/detect-rust-changes.test.cjs— 6/6 pass(the suite that covers the edited allowlist).
npx tsc --noEmit -p tsconfig.json— clean, no diagnostics. Note thisis weak evidence on its own:
packages/was never intsconfig.json'sinclude set, which is part of why the code was dead. The conclusive
check is the reference sweep below.
@orgii/ui,@orgii/marketplace,@orgii/orgii-core,ChatFontStyles,packages/ui,packages/orgiiacross the tree — zero hits post-change.
passed on the commit.
Not run: full
vitestandcargo test. No TypeScript or Rust sourceunder
src/orsrc-tauri/is modified, and the pre-commit hookreported "No TypeScript files staged, skipping type check" and "No Rust
files staged, skipping clippy" for the same reason. The one behavior this
PR does change — the CI Rust-skip allowlist — is covered by the
node --testrun above.