feat(replay): turn bands and pin-bar jump to WorkStation - #999
Open
beruro wants to merge 6 commits into
Open
Conversation
Color-code the simulator replay scrubber by chat turn and restore the hover navigate icon on turn collapse bars so users can orient and seek directly from the transcript. Pre-commit hook ran. Total eslint: 8, total circular: 0
Use canonical replay preview enum values and branded i18n test doubles after syncing the branch with current develop. Pre-commit hook ran. Total eslint: 0, total circular: 0
Use absolute-positioned turn bands on a dedicated timeline row beneath the scrubber, hide the drag handle in follow mode, and add turn-track aria copy for the new layout. Pre-commit hook ran. Total eslint: 0, total circular: 0
Keep replay preview enums and i18n test doubles aligned with current shared types after the timeline-track test expansion. Pre-commit hook ran. Total eslint: 0, total circular: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The WorkStation replay scrubber is a uniform timeline with no semantic landmarks, and the chat turn collapse bar ("Agent worked for …") had no quick way to jump into replay at that turn. Users scrubbing long sessions cannot see where each turn starts or navigate there in one click.
Solution
ReplayTurnTimelinerow beneath the scrubber (absolute-positioned segments on a pill track), replacing the earlier flex lane layout.TurnCollapsePinBarthat callsreplayEventById(turnId)to open WorkStation at the turn start (hidden inside Simulator Messages replay).Potential risks
--color-primary-6, etc.); untested in high-contrast theme.canReplaygating hides the pin-bar icon when no simulator events are loaded; imported/read-only sessions may not show it.Verification
pnpm exec vitest run src/engines/SessionCore/replay/__tests__/replayTurnSegments.test.ts src/engines/Simulator/components/MusicPlayerReplayBar/__tests__/replayTurnSegmentLabels.test.ts— 10 passed