Repository navigation
refactor: split commexch/prog to adapter/core - #34
Merged
Merged
Conversation
Split pool/compstep, proc/compstep, proc/commturn, proc/termdef and proc/typedef into an agnostic core/ package and a toolkit-specific adapter/ package, following the pool/typedef pilot and the layer-0 split. - Move the models, ports, behaviour and the query-builder port into core/, exporting identifiers that cross the boundary - Move the pgx DAO, sqlbuilder, goverter conversions, wire/view models and the fx module into adapter/ - Keep wire models (form/JSON tags, SDK references) in adapter/ - Keep SQL table names in adapter/ - Point consumers at the appropriate half - Make the proc/typedef query-builder test assert instead of print - Extend the boundary check to reject any agnostic core package importing the SDK Refs orglang/go-workspace#6
Import the engine core under the bare aggregate name (e.g. typedef, compstep, termexp) instead of a pool/proc-prefixed alias, and alias the wire-format SDK as sdk<agg> only when a same-named SDK package is also imported. Retain pool/proc prefixes only for genuine namesakes, and alias the shared kernel adt/compvar as adtcompvar where it collides with pool/compvar/core. Refs: orglang/go-workspace#6
pavetok
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move commexch and prog implementations into adapter/core layers to match repository layering conventions.
Changes: