Repository navigation
ci: release the Swift package separately from npm - #11
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe React publishing workflow no longer creates version tags. A manually triggered Swift release workflow validates the requested version, runs Swift tests, builds for the iOS 17 simulator, and creates a version tag at the triggering commit. The Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The documented 0.3.0 Swift release passes the version check, and release requests are queued. No concrete merge-blocking issue remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: QUIET
Plan: Advanced
Run ID: 8843b0eb-3811-44ac-ad12-d3c8667dd2c7
📒 Files selected for processing (6)
.github/workflows/publish-react.yml.github/workflows/release-swift.ymlREADME.mddocs/releases.mdjustfilescripts/check-swift-version.sh
💤 Files with no reviewable changes (1)
- .github/workflows/publish-react.yml
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.
#9 tied Swift tags to
@origin89/ui-reactreleases, so every Swift-only change needed an unrelated React changeset and npm publish. Several Swift releases are planned for the Apps setup flow (origin89hq/apps#1), so the Swift package now has its own version line.just swift-release 0.3.0dispatches the newrelease-swift.ymlonmain. It rejects anything but a plainX.Y.Zabove every existing Swift tag, runsswift testand the iOS 17 Simulator build on the dispatched commit, then creates the lightweight tag at that commit; an existing tag makes the API call fail rather than move. Runs are serialized withqueue: max, so releases dispatched while one is running wait instead of replacing each other. Theswift-tagjob is removed frompublish-react.yml, so npm releases no longer create plain tags that could collide with Swift versions.0.2.0remains the first Swift tag.Validation:
scripts/check-swift-version.shagainst the current tags accepts 0.2.1, 0.3.0, 0.10.0 and 1.0.0, and rejects 0.2.0, 0.1.9,v0.3.0,0.3,0.03.0,0.3.0-beta.1and an empty value. The workflow YAML parses andbiome cipasses; shellcheck was not available locally. The workflow itself has not run; the first dispatch after merge is its first real test.