Require all 3 osac e2e install checks on main

[eliorerz]

Summary

• repo_osac's required_status_checks was left empty in Terraform with a comment explaining osac had no CI yet at the time it was created. That's stale now: osac's own e2e-vmaas/e2e-bmaas/e2e-caas full-install workflows have been running and passing on real PRs for a while.
• Live-confirmed the gap: gh api repos/osac-project/osac/branches/main/protection currently returns required_status_checks: null -- a PR can merge into osac:main today even with every check failing.
• Adds all 3 e2e full-install checks as required (not just vmaas like the sibling component repos), since osac is now the repo everything actually merges into, not a pre-merge staging repo.

Verification

• tofu fmt -check -diff: clean.
• tofu validate (after tofu init -backend=false): valid, no new warnings (25 pre-existing unrelated deprecation warnings only).
• Actual plan/apply needs the S3 backend's CI credentials -- not runnable locally, same as every prior PR in this repo; relies on the existing apply pipeline.

Test plan

• Confirm the ruleset applies cleanly on the next Terraform apply cycle
• Confirm gh api repos/osac-project/osac/rulesets shows the new ci-status-checks ruleset with all 3 contexts
• Confirm a PR with a failing e2e check can no longer be merged

Summary by CodeRabbit

• CI
  • Updated required checks for the repo_osac module to include all OSAC end-to-end checks: VMAAS, BMAAS, and CAAS.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7fa03503-654d-4833-bce0-2760873157a4

📥 Commits

Reviewing files that changed from the base of the PR and between 3771c33 and 1ad6e51.

📒 Files selected for processing (1)

• repositories.tf

---

Walkthrough

The repo_osac module now requires the vmaas, bmaas, and caas full-install end-to-end CI checks.

Changes

OSAC CI requirements

Layer / File(s)	Summary
Require OSAC end-to-end checks repositories.tf	repo_osac now requires the vmaas, bmaas, and caas full-install end-to-end checks.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• osac-project/github-config#131: Migrates required status checks to GitHub rulesets.
• osac-project/github-config#136: Updates repo_osac required-status-check configuration.
• osac-project/github-config#148: Introduces the repo_osac module configuration updated here.

Suggested reviewers: larsks

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states that the pull request requires all three OSAC end-to-end installation checks on the main branch.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	The PR only adds three CI context names and the repeated numeric integration_id 15368; scans of added lines found no secret indicators or credential-shaped literals.
No-Weak-Crypto	✅ Passed	The commit only adds three CI status-check contexts and comments; added-line and repository searches found no weak crypto, custom crypto, or secret-comparison usage.
No-Injection-Vectors	✅ Passed	The PR only adds static Terraform status-check contexts and removes comments; no SQL, shell, eval/exec, unsafe YAML/pickle, os.system, or HTML injection vectors are introduced.
Container-Privileges	✅ Passed	The PR changes only repositories.tf status-check settings; no container/Kubernetes manifests or privilege-related fields were added.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only adds three public CI status contexts and comments; it adds no logging statements, credentials, tokens, PII, hostnames, or customer data.
Ai-Attribution	✅ Passed	The authored PR description and sole submitted commit do not mention AI tools; the commit has no trailers. Claude Co-Authored-By entries are only in base history.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch osac-required-status-checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}