Skip to content

Issue #190 solved: remove dead code left over from the Rust migration - #250

Merged
Sanjana-Siddani merged 1 commit into
oss-slu:mainfrom
PRINCEKK122:190-remove-dead-code
Nov 12, 2026
Merged

Sanjana-Siddani merged 1 commit into
oss-slu:mainfrom
PRINCEKK122:190-remove-dead-code

Conversation

@PRINCEKK122

Copy link
Copy Markdown
Collaborator

Closes #190.

What was dead

Path Why it is dead
relay/src/ipc.rs (113 lines) sits behind a commented-out // mod ipc; in main.rs, so it is not part of the crate and is never compiled
relay/src/channel.rs (6 lines) never declared as a module at all
src/clientserver/ Cargo.toml declares binaries at src/server.rs and src/client.rs; neither file exists, so the crate cannot build. Nothing references it
src/client.rs orphan at the repo's src/ root, referenced only by those broken binary paths

src/clientserver is worth calling out: cargo check inside it fails with can't find bin 'server'. It has been unbuildable, not merely unused.

What was kept

The live IPC types are ToIpcThreadMessage and FromIpcThreadMessage in relay/src/message.rs, used by the IPC thread in state.rs. Those are untouched. The deleted ipc.rs is a separate, unreferenced module that happens to share the name.

The channel:: references in state.rs and bichannel.rs are all crossbeam::channel, the external crate, not the deleted local module.

Testing

  • relay: 21 passed, 2 failed — unchanged from clean main. The two failures are a_slow_python_reader_does_not_pace_imotions and a_python_process_that_stops_reading_is_dropped_not_waited_on, both from Mirror the relay's packets to a second destination for Python #247, and both fail on main here too. I will raise that separately; it is not caused by this change.
  • src/server: 5 passed.
  • baton: builds.
  • No reference to any deleted path remains in the Markdown docs, workflows or manifests.

…gration

Four things in the tree that nothing compiles or references:

relay/src/ipc.rs is 113 lines behind a commented-out `// mod ipc;` in
main.rs. relay/src/channel.rs is 6 lines that were never declared as a
module at all. Neither is part of the crate, so neither is compiled.

src/clientserver is a crate that cannot build: its Cargo.toml declares
binaries at src/server.rs and src/client.rs, and neither file exists.
Nothing references the crate. src/client.rs at the repo's src/ root is
the orphan those binary paths were presumably meant to point at.

The live IPC types are ToIpcThreadMessage and FromIpcThreadMessage in
message.rs, which are untouched; the deleted ipc.rs is a separate
unreferenced module.

relay, src/server and baton all build, and the relay's test results are
unchanged: 21 passed, 2 failed, the two failures being the mirror tests
from oss-slu#247 that also fail on clean main here.
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@Sanjana-Siddani
Sanjana-Siddani self-requested a review November 11, 2026 18:40

@Sanjana-Siddani Sanjana-Siddani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Nothing in the repo uses any of the deleted files, and relay and server both still build. The 2 failing relay tests also fail on main right now (#251), so they’re not from this PR. Approving

@Sanjana-Siddani
Sanjana-Siddani merged commit ce1f642 into oss-slu:main Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead code left over from the Rust migration

2 participants