Menu mobile : ajout d'un titre "fermer" - #1586
Open
Olivia206 wants to merge 1 commit into
Open
Conversation
Contributor
djLintHugolintDirectories are perfect ✅Partials calls are perfect ✅Lines are perfect ✅Complexity is perfect ✅ |
Olivia206
marked this pull request as ready for review
August 25, 2026 13:47
Olivia206
requested review from
SebouChu,
alexisben,
arnaudlevy and
pabois
as code owners
August 25, 2026 13:47
Member
|
Pourquoi ne pas donner une classe ? |
Contributor
Author
|
c'est à dire ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Ajout du titre "fermer" au bouton de menu mobile, lorsqu'il est ouvert.
Plus un peu de rangement dans le style, très léger
Niveau d'incidence
Référence (ticket et/ou figma)
#992
Impact
On utilise span:not(:first-child) à de nombreux endroits pour masquer le texte du bouton : https://github.com/search?q=org%3Aosunyorg%20header-button&type=code, il faut donc appliquer ce fonctionnement aux deux premiers span
URL de test sur example.osuny.org
http://localhost:1313/fr/Screenshots