Repository navigation
Document TLS serving and the exit status in the README - #1
Merged
Merged
Conversation
…lure The serve section said only plain Modbus TCP is served and the --url row named only tcp://host:port, while serve accepts tcp+tls:// with --tls-cert, --tls-key and --tls-ca (serve.go, tls.go) and the README's own "Serving over TLS" section documents it. The FAQ said the exit status is "non-zero" on failure; main.go exits with 1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016fpDM86uFLh3cRtBXmhJDQ
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Bart Van Bos · project thread
Before: the serve section said "Only plain Modbus TCP is served" and its
--urlrow named onlytcp://host:port, although the README documents serving overtcp+tls://further down. The scripting FAQ only said a failed command exits "non-zero".After: the serve section and the
--urlrow cover bothtcp://andtcp+tls://(with--tls-cert,--tls-key,--tls-ca) and link to "Serving over TLS". The FAQ says the exit status is 0 on success and 1 on failure.How: documentation only, checked against serve.go, tls.go and the
os.Exit(1)in main.go.Generated by Claude Code