This repository was archived by the owner on Aug 23, 2026. It is now read-only.
refactor: remove LicenseInjection field from Workspace spec - #148
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated LicenseInjection field from the Workspace API (Go type + generated CRD schema), simplifying the Workspace spec surface area and ensuring the CRD no longer advertises/supports that setting.
Changes:
- Removed
LicenseInjectionfromtenant/v1alpha1.WorkspaceSpec. - Removed
spec.licenseInjectionfrom theWorkspaceCRD OpenAPI schema.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tenant/v1alpha1/workspace_types.go | Drops LicenseInjection from the WorkspaceSpec Go API type. |
| config/crd/bases/tenant.otterscale.io_workspaces.yaml | Removes the licenseInjection property from the CRD schema to match the Go type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.