This repository was archived by the owner on Aug 23, 2026. It is now read-only.
refactor: remove GetAgentManifest RPC and related types from LinkService - #149
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the GetAgentManifest RPC from otterscale.link.v1.LinkService and cleans up all generated artifacts (TypeScript, Go, and OpenAPI) so the API surface is consistent across protobuf, Connect, and OpenAPI outputs.
Changes:
- Removed
GetAgentManifestRPC fromproto/link/v1/link.proto. - Removed
GetAgentManifest{Request,Response}message types from generated TypeScript and Go protobuf outputs. - Removed
GetAgentManifestendpoints and schemas from the generated OpenAPI spec, and removed the RPC from the generated Go Connect client/handler.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ts/src/link/v1/link_pb.js | Updates generated TS protobuf descriptors to remove GetAgentManifest types/service method metadata. |
| ts/src/link/v1/link_pb.d.ts | Removes the exported TS types and service method signature for GetAgentManifest. |
| proto/link/v1/link.proto | Deletes the GetAgentManifest RPC and its request/response messages from the source proto. |
| openapi/openapi.yaml | Removes the /GetAgentManifest path entries and related request/response component schemas. |
| link/v1/link.pb.go | Updates generated Go protobuf code: removes GetAgentManifest messages and service descriptor entries. |
| link/v1/link.connect.go | Updates generated Go Connect client/handler code to remove the GetAgentManifest procedure and wiring. |
Files not reviewed (2)
- link/v1/link.connect.go: Generated file
- link/v1/link.pb.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.