feat: add stdin to run_skill_script - #59
Merged
Merged
Conversation
Signed-off-by: Michele Papalini <micpapal@cisco.com>
micpapal
force-pushed
the
feat/add-stdin
branch
from
September 11, 2026 07:23
147c9f4 to
8de2eb7
Compare
micpapal
marked this pull request as ready for review
September 11, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run_skill_scripthas no way to feed stdin to the scripts it runs.sandbox.run_script()'ssubprocess.run(...)call never passes astdin=/input=argument, so a launched script inherits this process's own stdin — which never produces data or an EOF here. Any script that reads stdin (e.g. a--file -/ "or on stdin" convention) blocks until timeout.Found via a real failure: an agent calling
concord.py record reply --file -to record an agent's reply. Every call timed out (exit_code: 124).Fix
sandbox.run_script()gainsstdin: str = "", always passed assubprocess.run'sinput=— immediate EOF when empty, real content when given. Either way, nothing blocks waiting for stdin that will never arrive.run_skill_script's tool schema gains a matching optional"stdin"parameter, threaded through to the call above.