Repository navigation
fix: build with Go 1.27.3 (GO-2026-6809 in crypto/x509) - #128
Merged
Merged
Conversation
govulncheck now fails every run: Go 1.27.2's crypto/x509 trusts compromised intermediate certificates (GO-2026-6809), reached from any TLS call such as socrate.Client.StreamSecurityEvents; Go 1.27.3 fixes it. The toolchain line, the CI jobs and the docs move to 1.27.3. The go line, the floor importers need, stays at 1.26.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013GcASrGGa8qWVV78mbXJoa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it changes
govulnchecknow fails on every run,mainincluded, with GO-2026-6809: Go 1.27.2'scrypto/x509trusts compromised intermediate certificates. Go 1.27.3 fixes it. The reported trace issocrate.Client.StreamSecurityEvents→x509.Certificate.Verify, but any TLS call reaches it. The failure first showed on #127, which only touches workflow YAML.This PR moves the toolchain to 1.27.3:
toolchainline ingo.mod;go-versionof the CI jobs that run the toolchain (build & test, golangci-lint, govulncheck);The
goline, the floor importers need, stays at 1.26.0. Importers get the fix by building with Go 1.27.3 or later. tenure-api already does.A line is added under
## [Unreleased](Security) inCHANGELOG.md.How it was tested
Locally with Go 1.27.3:
go mod tidy(go.sum unchanged);go build ./...;go vet ./...;go test -race ./...;golangci-lint run ./...(0 issues).govulncheckcannot reach vuln.go.dev from my environment, so this PR's own CI run is the check that matters.Exported API
None.
Generated by Claude Code