Skip to content

[dropshot_endpoint] reuse is_wildcard_path in endpoint validation #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunshowers wants to merge 1 commit into from
Open

[dropshot_endpoint] reuse is_wildcard_path in endpoint validation #1699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dropshot_endpoint/src/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ impl EndpointMetadata {
));
}

if path.contains(":.*}") && !self.unpublished {
if is_wildcard_path(&path) && !self.unpublished {
errors.push(Error::new_spanned(
attr,
format!(
Expand Down Expand Up @@ -459,7 +459,7 @@ impl ChannelMetadata {
get_crate(self._dropshot_crate.as_deref())
}

/// Validates metadata, returning a `ValidatedChannelMetadata` is valid.
/// Validates metadata, returning a `ValidatedChannelMetadata` if valid.
///
/// Note: the only reason we pass in attr here is to provide a span for
/// error reporting. As of Rust 1.76, just passing in `attr.span()` produces
Expand Down