Repository navigation
build and release the CLI for Windows on ARM64 - #1552
sunshowers merged 1 commit into
Conversation
| aarch64-apple-darwin = "macos-14" | ||
| aarch64-pc-windows-msvc = "windows-11-arm" | ||
| x86_64-apple-darwin = "macos-14" |
There was a problem hiding this comment.
Alphabetized this and the list above.
ahl
left a comment
There was a problem hiding this comment.
was this tested with our fork of dist?
Revision history
Generated by jj-stack from this pull request's force-push history. |
e99a620 to
8b63b8e
Compare
|
Moving to draft while I test. |
8b63b8e to
f36cf0e
Compare
|
Seems to work great! https://github.com/oxidecomputer/oxide.rs/actions/runs/36530091327?pr=1554 has aarch64-pc-windows-msvc in its artifact list now. |
|
Tested the binaries built in #1554 (see workflow artifacts) on a Snapdragon Surface Pro, by logging into the colo rack -- works great. |
|
Actually I want to double check a few more things. |
Adds aarch64-pc-windows-msvc to the dist targets -- with this there will be a `oxide-cli-aarch64-pc-windows-msvc.zip`. Noticed this while trying out `winget install OxideComputer.OxideCLI` on a Surface tablet.
f36cf0e to
a4c8882
Compare
|
Okay, simplified this down -- this works great and is ready for review. (Code signing is currently broken, so we'll probably need to update cargo-dist again, but that doesn't need to block landing this.) |
| [target.aarch64-pc-windows-msvc] | ||
| rustflags = [ | ||
| "-C", "link-args=/STACK:8388608", | ||
| ] | ||
|
|
There was a problem hiding this comment.
do we need the gnu equivalent as below?
There was a problem hiding this comment.
Hmm, there's no aarch64-pc-windows-gnu, but there is gnullvm for both x86_64 and aarch64. https://doc.rust-lang.org/rustc/platform-support/windows-gnullvm.html
Given that we don't even try to build gnullvm on any arch, probably not?
Adds
aarch64-pc-windows-msvcto the dist targets -- with this there will be aoxide-cli-aarch64-pc-windows-msvc.zip.Also update cargo-dist to 1.0.18 to pick up oxidecomputer/cargo-dist#340.
Noticed this while trying out
winget install OxideComputer.OxideCLIon a Surface tablet.