Skip to content

Earlier permissions for set_rfd_attr; bound AsciiDoc expansion - #614

Merged
notpeter merged 4 commits into
single-line-stringfrom
denial_of_service
Nov 12, 2026
Merged

notpeter merged 4 commits into
single-line-stringfrom
denial_of_service

Conversation

@notpeter

@notpeter notpeter commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 robot:
An anonymous internet caller can crash the rfd-api process with one request of up to 1 MiB, and can repeat it after every restart. The request must target an RFD the caller can read, such as a public one, whose stored document has no :authors: header line before the edited attribute.

Claude Link (team-shared):
https://claude.ai/code/cshk_01Q5Ej2cHBc7wgaksc9BPkaiPgvaeaJszgNYbzxzfE9Cj5

@notpeter
notpeter requested a review from augustuswm November 11, 2026 21:44
Comment thread rfd-api/src/endpoints/rfd.rs Resolved
Comment thread rfd-api/src/endpoints/rfd.rs Resolved
Comment thread rfd-api/src/endpoints/rfd.rs Resolved
Comment thread rfd-data/src/content/asciidoc.rs Resolved
Comment thread rfd-api/src/endpoints/rfd.rs Resolved
@notpeter
notpeter changed the base branch from main to single-line-string November 12, 2026 14:10
@notpeter
notpeter added this pull request to stack #616 November 12, 2026 14:11
The permission check now lives in the context and wraps the update,
instead of an early return in the endpoint. The latest revision is
fetched once and used for both the edited content and the base commit.
@notpeter
notpeter requested a review from augustuswm November 12, 2026 15:28
@notpeter
notpeter merged commit 152fda9 into main Nov 12, 2026
12 checks passed
@notpeter
notpeter deleted the denial_of_service branch November 12, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants