Repository navigation
Conversation
scrollMain handled the log and text views, then fell through to the table branch. With the in-panel shell open, the wheel over the pane moved the hidden table's selection, so detaching landed on a different row. It now returns early in shell mode. This is the first acceptance item of Part 1 in p10node#12. Scrollback and passing the wheel to programs in the pod are still open there. Refs p10node#12 Signed-off-by: Ehab Kahwati <iehab.kahwati@gmail.com>
pierreneter
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12, the first acceptance item of Part 1.
With the in-panel shell open, the wheel over the pane goes to
scrollMain, which handles logs and text and then falls through to the table branch. So it moved the hidden table'srowIdx/rowMem, and detaching landed on a different row.scrollMainnow returns early in shell mode.The regression test sits next to
TestShellSizedToThePanel: two wheel ticks over the shell pane leave the selection alone. On main it fails withrow 0 -> 4.go vet ./...,go test ./...andgo test -race ./internal/ui/pass.Scrollback and passing the wheel to programs in the pod are still open in #12. I kept this PR to the fall-through so it's easy to review.