Repository navigation
fix(cli): say in --help that read-only blocks every external plugin - #39
Merged
Merged
Conversation
Read-only mode refuses every external plugin, whatever `dangerous` says (internal/ui/plugins.go), as docs/commands.md, docs/plugins.md and SECURITY.md say. The --help text and the comment on Model.readOnly still said only dangerous plugins were blocked. Signed-off-by: Adao Oliveira Jr <junior@users.noreply.github.com>
This was referenced Nov 12, 2026
pierreneter
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the review of #28:
k10s --helpsaid read-only mode blocks "dangerous plugins", but it blocks every external plugin (internal/ui/plugins.go), as docs/commands.md, docs/plugins.md and SECURITY.md say. The comment onModel.readOnlysaid the same. Both now say external plugins.gofmt, vet and
go test -short ./...pass on Go 1.26.11 and 1.27.4.