Repository navigation
Conversation
The bar rounds its scroll position to a whole line in its scroll handler, which runs a frame after the browser scrolled the caret into view. The test read scrollTop right after typing and sometimes saw the browser's partial scroll (1.77 lines instead of 2); it now waits up to 2 s for the snap before asserting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formula bar test in
e2e/xlsx.spec.tsfails now and then in CI withExpected: 2, Received: 1.7666….The bar rounds its scroll position to a whole line in its scroll handler, which runs a frame after the browser scrolled the caret into view. The test read
scrollTopright after typing, and sometimes saw the browser's partial scroll (1.77 lines instead of 2). It now waits up to 2 s for the snap before asserting. Only the test changes.🤖 Generated with Claude Code