Skip to content
This repository was archived by the owner on Oct 20, 2026. It is now read-only.

Plain-language user-facing messages (no internal planning refs) - #2

Merged
drietsch merged 1 commit into
mainfrom
fix/ui-text-internal-refs
Oct 11, 2026
Merged

drietsch merged 1 commit into
mainfrom
fix/ui-text-internal-refs

Conversation

@drietsch

Copy link
Copy Markdown
Contributor

User-visible strings cited internal tracker/ADR ids. They now say plainly what is happening or what the user can do. Code comments and log-only lines keep their references.

Where Before After
session.ts (merge to new document) this host cannot open a second document (no documents door, D-26) — … this editor version cannot open a second document — merge into the current document instead
session.ts (remote source status) Inert — origin consent required before any fetch (D-03). Inert — allow this origin before anything is fetched.
session.ts (capture warning) …bytes of the 65536-byte document-metadata cap (D-08) — … the captured data sets take N of the 65536 bytes a document can store for them — …
remote.ts / data-sources remote.rs … use a credentialRef (D-11) … use a stored credential instead
data-js core.rs (graph-data variable note) … isolation contract forbids reaching into it (RFI D-15) graph-data variables are kept in the library but cannot be applied: paged.data does not fill charts
manifest.json property summaries (ADR 131) / (ADR 132) dropped

The listed bindings-panel.tsx "ADR 553" occurrence is now only in code comments on main, so it is unchanged.

Version: @paged-media/data 0.1.0-canary.13 → 0.1.0-canary.14 (bundle src + manifest are package-hash inputs).

Tests updated: data-conformance/tests/variables.rs, src/__tests__/remote.test.ts, src/__tests__/variables.test.ts.

Local results:

  • cargo test -p data-sources -p data-js -p data-conformance: 230 passed, 0 failed
  • wasm rebuilt (scripts/build-wasm.sh, wasm-bindgen 0.2.128) for the wasm-fresh check
  • pnpm typecheck: ok
  • REQUIRE_REAL_ENGINE=1 REQUIRE_REAL_DUCKDB=1 pnpm test: host-model 53/53, bundle 374 passed / 2 skipped
  • pnpm validate:manifest: valid; package-hash --check: ok (new version)

🤖 Generated with Claude Code

User-visible strings (source status, payload warning, credential error,
second-document notice, graph-data variable note, manifest property
summaries) cited internal tracker and ADR ids (D-03, D-08, D-11, D-15,
D-26, ADR 131/132). They now say plainly what the user can do or what is
not supported. Code comments keep their references.

Bumps @paged-media/data to 0.1.0-canary.14 (bundle src + manifest changed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@drietsch
drietsch merged commit 445c41b into main Oct 11, 2026
4 of 5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant