feat: v0727 improve - #87
Merged
Merged
Conversation
- Updated the description and functionality of the internal-github skill to serve as the official entry point for GitHub tasks, routing requests to the appropriate specialists or to internal-github-strategic for high-level decision framing. - Removed legacy references and clarified usage guidelines to prevent ambiguity in routing. - Enhanced test cases to validate the new routing logic and ensure proper handling of strategic requests. - Updated agent metadata to reflect the new skill structure and descriptions across AWS, Azure, GCP, and GitHub skills.
…d accuracy - Updated Python script reporting guidelines to enhance clarity on human-facing output and dependency decisions. - Revised internal-python SKILL.md to better define ownership routing and baseline usage. - Improved OpenAI agent prompts for internal-python to reflect updated descriptions. - Enhanced review-anti-patterns documentation for internal-python with clearer categorization of defects. - Added routing cases and tests for internal-java to ensure accurate ownership mapping. - Created tests for internal-nodejs to validate descriptions and ownership boundaries. - Expanded tests for internal-python to cover distinct trigger branches and routing logic. - Ensured project skills adhere to repository conventions and maintain clear reporting boundaries.
…r clarity and usage guidance
…, Node.js, and Python tests
…ty, coverage, and accuracy
- Updated descriptions and user invocability for internal-github-operations, internal-github-pr, internal-github-strategic, and internal-github skills to enhance clarity on usage and routing. - Streamlined the decision-making workflows and evidence collection processes in internal-github-operations and internal-github-strategic. - Improved the PR workflow in internal-github-pr to ensure better adherence to repository templates and validation criteria. - Enhanced routing matrix in internal-github to provide clearer guidance on primary deliverables and decision-making paths. - Adjusted agent prompts for OpenAI interfaces to reflect new routing commands and improve user experience.
…, and explicitness across multiple skills
- Updated descriptions and workflows for internal-azure-operations, internal-azure-organization-structure, and internal-azure-strategic skills to enhance usability and specificity. - Streamlined routing processes in internal-azure to better direct requests to appropriate specialists. - Improved documentation in references for validation, evidence, and routing scenarios to provide clearer guidance. - Adjusted agent prompts to reflect new workflows and ensure accurate user guidance.
- Updated descriptions and prompts in various skills to enhance clarity on their purpose and usage. - Revised the guardrail map and validation references to improve the structure and readability of operational guidance. - Streamlined the routing matrix to emphasize primary deliverables and clarify multi-domain sequencing. - Enhanced the strategic skill to better frame decision-making processes and clarify the use of lenses. - Adjusted the internal GCP entry point to ensure it effectively routes requests to the appropriate specialist based on deliverables.
- Updated workflow contract tests for internal-gateway-idea to reflect new critical consensus handling. - Revised internal GCP routing contract tests to improve structure and add new validation checks for specialist skills. - Enhanced internal GitHub routing contract tests with clearer descriptions and additional validation for routing logic. - Added tests for Java profiles to ensure deterministic skill membership including GitHub skills. - Cleaned up unnecessary imports and improved test readability across various test files. - Expanded cross-skill invocation tests to include new GitHub specialists and ensure proper invocation logic.
…arity and automatic plan handoff
- Updated SKILL.md to include new responsibilities for plan execution, such as capturing validation baselines and classifying failures. - Modified openai.yaml to reflect changes in execution prompts and requirements for user-facing reports. - Added baseline validation and recovery attempts sections to valid-plan.PARTIAL.md and valid-plan.md. - Enhanced execution contract in execution-contract.md to include new validation and recovery policies. - Updated status contract in status-contract.md to clarify status definitions and required headings. - Improved plan_execution.py to validate new execution fields and ensure recovery policies are actionable. - Added tests to validate the presence of new execution fields and ensure recovery evidence is actionable. - Updated validate_plan.py to check for new recovery and escalation conditions in plans. - Enhanced test coverage for execution recovery and validation processes in test_plan_execution.py and test_validate_plan.py.
- Deleted test files for review code simplification and review engine contracts. - Removed JSON fixture for review cases and corresponding test cases. - Cleaned up internal skill creator tests, including cross-skill invocation and contract validation. - Eliminated retired AI resource review tests and internal TDD skill contract tests. - Updated repository test layout contract by removing outdated guidance checks.
…or mattpocock-teach skill
…rtions in test files
…s and preflight requirements
… update tests - Added mechanical safety boundary section to execution contract. - Revised required headings in status contract to include optional evidence. - Updated plan execution script to handle new validation rules and notice codes. - Removed deprecated validate_plan script and replaced it with improved validation logic. - Enhanced tests to reflect changes in validation criteria and ensure compatibility between writing and execution plans. - Removed invalid plan fixture and updated valid plan fixture for consistency with new requirements.
… fields and updating references
…lds and updating references
… workflow clarity
…on logic, documentation updates, and test cases
…closeout decision logic, and CLI validation updates
…on and error handling
…d commit metadata
…hots and update related documentation
…orkflow execution
…lidation improvements - Updated SKILL.md to include requirements for a versioned Execution Contract in retained plans. - Modified openai.yaml to reflect changes in plan validation and execution handoff processes. - Added a valid execution contract example in the fixture for testing plan execution. - Refined sync_external_resources_core.py by removing unnecessary blank lines. - Improved test_plan_execution.py to enhance validation and closeout logic, ensuring proper handling of execution contracts and validations. - Updated test_execution_compatibility.py to assert that findings are empty for actionable plans.
…ramework - Updated the description and invocation process for the internal-gateway-codebase-improvement skill to clarify its purpose and workflow. - Enhanced the OpenAI agent configuration to reflect changes in the skill's functionality. - Introduced a protected skill boundary to prevent unauthorized modifications to certain skill bundles. - Added a new Makefile target for validating skill change scopes. - Implemented a comprehensive evaluation framework for scoring sanitized observations from controlled runs of the codebase-improvement gateway. - Created tests for the evaluation framework, including passing and failing scenarios, to ensure compliance with the defined contract. - Updated existing tests to accommodate changes in the skill and evaluation logic. - Ensured that all generated artifacts adhere to the new workspace normalization rules.
…ect_changed_paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance clarity and functionality of internal gateway skills, improve documentation, and refine validation processes. This update includes refactoring of existing skills, addition of new skills, and updates to existing configurations to ensure better usability and consistency.
Change Type
List of changes
Consumer Impact
Testing Instructions
Validation Evidence
Breaking Changes
Checklist