fix: bumpSnapshot increments patch instead of minor version - #183
Conversation
Maintainability Review
FindingsPriority: low |
|
@forkline why not choose in the release skill if it has to be major, minor or patch. |
|
@forkline but it is better to choose it when we are going to release. We don't have to prepare next release cycle after releasing. |
|
Updated the release skill to move the bump type decision (major/minor/patch) into the release step itself. The next snapshot version is now prepared immediately after pushing the release, not as a separate later step. |
|
@forkline how could we rework that skill to remove step 8. It just to happen before releasing |
|
@forkline I will try to explain my self better: you should not prepare next release cycle. When you release, at the beginning, you choose the version and prepare the release. Then, you do nothing, not prepare or do nothing more. |
There was a problem hiding this comment.
Updated the release workflow to remove post-release snapshot preparation. The release skill, RELEASE.md, and setup-android-release skill now follow this flow:
- At release time: choose bump type (major/minor/patch) and bump the version directly
- Commit, push, monitor CI
- Done — no snapshot bumping after release
The version stays at the release value until the next release is cut.
Problem
The
bumpSnapshotgradle task was callingversion.nextMinorVersion("SNAPSHOT"), which caused every release cycle to jump a minor version (e.g., 1.23.0 → 1.24.0-SNAPSHOT → 1.24.0 → 1.25.0-SNAPSHOT).Fix
Changed
bumpSnapshotto useversion.nextPatchVersion("SNAPSHOT")so the version increments the patch component instead (e.g., 1.23.0 → 1.23.1-SNAPSHOT → 1.23.1 → 1.23.2-SNAPSHOT).This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.