Skip to content

fix(chat): show the fields of omp's ask form instead of cancelling them - #42

Merged
pandudpn merged 1 commit into
mainfrom
fix/form-dialogs
Nov 15, 2026
Merged

pandudpn merged 1 commit into
mainfrom
fix/form-dialogs

Conversation

@pandudpn

Copy link
Copy Markdown
Owner

omp 18.19 made the ask tool take an HTML form. Over RPC, omp asks that form one field at a time with plain select/input/editor dialogs. ompwire cancelled those dialogs because they were neither an approval nor an ask, and a single cancelled field fails the whole ask. The chat never saw the question, and the turn ended with "Ask tool was cancelled by the user".

Seen live on vidura-demon:

dialog cancelled chat=749994884 method=select title='Target'
tool done 749994884 tool=ask status=failed
turn end chat=749994884 stop=cancelled

Change

  • select (not an approval), input and editor dialogs now open the same question card that ask uses.
  • The card drops omp's Other (type your own) option because it already has an Other button. Typed text that matches an option picks that option. Other text answers omp's Other option, then fills the input omp opens next.
  • Skip sends {cancelled, timedOut}, so the field keeps its default and the form continues. editor has no timeout path, so Skip sends its prefill.
  • ARCHITECTURE.md documents this behavior.

Tests

  • 7 new tests in tests/test_ask_flow.py. The 6 form-field tests fail on main and pass here.
  • Full suite: 801 passed. ruff check is clean.

omp 18.19 changed the ask tool's argument to an HTML form. omp's RPC host
has no form dialog, so it asks the form one field at a time through plain
`select`, `input` and `editor` dialogs instead of the `ask` request.
ompwire cancelled every dialog that was not an approval or an `ask`, and
omp fails the whole ask on any cancelled field, so the agent saw "Ask tool
was cancelled by the user" and the turn ended before the chat saw the
question.

Each field now gets the options card. omp's own "Other (type your own)"
entry is left off because the card has an Other button. Text that names
an option picks it. Any other text on a group answers omp's Other entry
and then fills the input omp opens for it. Skip answers
{cancelled, timedOut} so the field keeps its default. An editor has no
timeout path, so Skip there answers with the prefill.
@pandudpn pandudpn Bot added bug Something isn't working labels Nov 15, 2026
@pandudpn
pandudpn merged commit e01bc3d into main Nov 15, 2026
6 checks passed
@pandudpn
pandudpn deleted the fix/form-dialogs branch November 15, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant