fix: map seven nested response objects the API returns - #413
Merged
danielabbatt merged 1 commit intoSep 9, 2026
Merged
Conversation
The same sweep of unmapped-member reports that found the scalars in 1.70.135 also found seven nested objects with no model property. Callers who set JsonMissingMemberHandling.ThrowOnError were getting a failed deserialization rather than an ignored field: TwoPointFourGhzSettings.Dot11ax and FiveGhzSettings.Dot11ax SwitchPort.PerpetualPoe and .FastPoe NetworkApplianceSsidRadiusServer.Radsec Admin.OtherOrganizationAccounts VpnBgp.Ipv6 and .TunnelDownTermination Ten new classes back them, named after their owners in line with the existing SwitchPortDot3az / ConfigTemplateSwitchProfilePortDot3az split. Dot11ax on both bands and both PoE objects are in the v1.74.0 OpenAPI spec on request bodies as well as responses, so Dot11ax is read/write and the PoE objects are read/update, matching their endpoints. The spec also marks axEnabled deprecated in favour of dot11ax.enabled on both bands, which the XML docs now say. Radsec, OtherOrganizationAccounts, Ipv6 and TunnelDownTermination appear nowhere in the spec and are mapped read-only from the observed responses. MissingMemberNestedFieldTests covers all seven, deserializing the observed payloads with MissingMemberHandling.Error; the CI step added in 1.70.135 runs them.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 8 complexity
Metric Results Complexity 8
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #412 — base is
fix/map-observed-scalar-fields, so merge #412 first, after which this can be retargeted tomain.The same unmapped-member export that found #412's scalars also found seven nested objects with no model property. Callers who set
JsonMissingMemberHandling.ThrowOnErrorwere getting a failed deserialization rather than an ignored field.TwoPointFourGhzSettings.Dot11axTwoPointFourGhzSettingsDot11ax?FiveGhzSettings.Dot11axFiveGhzSettingsDot11ax?SwitchPort.PerpetualPoeSwitchPortPerpetualPoe?SwitchPort.FastPoeSwitchPortFastPoe?NetworkApplianceSsidRadiusServer.RadsecNetworkApplianceSsidRadiusServerRadsec?Admin.OtherOrganizationAccountsAdminOtherOrganizationAccounts?VpnBgp.Ipv6VpnBgpIpv6?VpnBgp.TunnelDownTerminationVpnBgpTunnelDownTermination?New classes
Ten, each named after its owner in line with the existing
SwitchPortDot3az/ConfigTemplateSwitchProfilePortDot3azsplit rather than sharing oneenabled-only type:TwoPointFourGhzSettingsDot11ax,FiveGhzSettingsDot11ax,SwitchPortPerpetualPoe,SwitchPortFastPoe,NetworkApplianceSsidRadiusServerRadsec,AdminOtherOrganizationAccounts,AdminOtherOrganizationAccountsLockout,VpnBgpIpv6,VpnBgpIpv6SinglePeering,VpnBgpTunnelDownTermination.Access decisions
Dot11axon both bands and both PoE objects appear in v1.74.0 request bodies as well as responses, so they are writable. The spec also marksaxEnableddeprecated in favour ofdot11ax.enabledon both bands, which the XML docs now say — no behaviour change,AxEnabledis left in place.Radsec,OtherOrganizationAccounts,Ipv6andTunnelDownTerminationappear nowhere in the spec and are mapped read-only from the observed responses.Tests
New
Meraki.Api.Test.Data.MissingMemberNestedFieldTests, same approach as #412: observed payloads (identifying values replaced) deserialized withMissingMemberHandling.Error. Run by the CI step #412 adds.Notes
1.70.136, one above fix: map seven scalar response fields the API returns #412's; merge commits will shift the released number.SixGhzSettingshas nodot11axin the spec or in any observed response, so it is untouched.