feat: map the Live Tools and general members from the 1.74.0 gap report - #422
Open
danielabbatt wants to merge 2 commits into
Open
Conversation
Nineteen members the v1.74.0 spec documents that the models lacked, the sixth and last per-area batch, which closes every member the report listed: Client.Cdp; ClientProvision.ClientId and .Message; DeviceClient .AdaptivePolicyGroup and .Switchport; Mac on both MAC-table request types; IpVersion, Vrf and VrfType on the multicast routing interface and route types; Events.ClientMac; LiveToolsArpTableResultTableEntry.Interface; LiveToolsThroughputTestCreateResponse.ThroughputTestId; and the API's current startTime/endTime and received names alongside the legacy ones on LossAndLatencyHistory, SubclassApplicationUsage and SubclassUsageHistory. Find-MissingModelMembers.ps1 now reports no unmapped response members against v1.74.0. LiveToolsGeneralMemberTests covers the batch.
With every member mapped, the summary line indexed .ClrType on an empty array, which Set-StrictMode rejects. Count the types only when there are findings.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #421 → #420 → #419 → #418 → #417 → #416 → #415
Base is
feat/map-switch-camera-sensor-cellular-members. Merge the chain in order with merge commits, then retarget this tomain. Changelog label1.74.19assumes that.What
Sixth and last per-area batch from
gap-report-v1.74.0.md: 19 Live Tools and general members, all scalars exceptClient.Cdp.ClientCdp—List<List<string>>?, the API returns CDP as a list of two-element name/value listsClientProvisionClientId,MessageDeviceClientAdaptivePolicyGroup,SwitchportDeviceLiveToolsMacTable{Create,Get}ResponseRequestMacDeviceLiveToolsMulticastRoutingGetResponse{Interface,Route}IpVersion,Vrf(+VrfTypeon the interface)EventsClientMacLiveToolsArpTableResultTableEntryInterfaceLiveToolsThroughputTestCreateResponseThroughputTestIdLossAndLatencyHistory,SubclassApplicationUsage,SubclassUsageHistorystartTime/endTime/receivedalongside the legacystartTs/endTs/recv— as withWifiin #420, I don't know which set the live API sends, so nothing was removedWhere this leaves the gap report
After this chain merges,
Find-MissingModelMembers.ps1reports 0 unmapped response members against v1.74.0 (from 155). What it still reports, and what this series did not touch:Both need their own pass; the ApiChecker project is the existing tool for the endpoint side.
Verification
All 13 edited files kept their BOM state.