Skip to content

feat: map the Live Tools and general members from the 1.74.0 gap report - #422

Open
danielabbatt wants to merge 2 commits into
feat/map-switch-camera-sensor-cellular-membersfrom
feat/map-livetools-general-members
Open

feat: map the Live Tools and general members from the 1.74.0 gap report#422
danielabbatt wants to merge 2 commits into
feat/map-switch-camera-sensor-cellular-membersfrom
feat/map-livetools-general-members

Conversation

@danielabbatt

Copy link
Copy Markdown
Contributor

Stacked on #421#420#419#418#417#416#415

Base is feat/map-switch-camera-sensor-cellular-members. Merge the chain in order with merge commits, then retarget this to main. Changelog label 1.74.19 assumes that.

What

Sixth and last per-area batch from gap-report-v1.74.0.md: 19 Live Tools and general members, all scalars except Client.Cdp.

Model Added
Client CdpList<List<string>>?, the API returns CDP as a list of two-element name/value lists
ClientProvision ClientId, Message
DeviceClient AdaptivePolicyGroup, Switchport
DeviceLiveToolsMacTable{Create,Get}ResponseRequest Mac
DeviceLiveToolsMulticastRoutingGetResponse{Interface,Route} IpVersion, Vrf (+ VrfType on the interface)
Events ClientMac
LiveToolsArpTableResultTableEntry Interface
LiveToolsThroughputTestCreateResponse ThroughputTestId
LossAndLatencyHistory, SubclassApplicationUsage, SubclassUsageHistory the API's current startTime/endTime/received alongside the legacy startTs/endTs/recv — as with Wifi in #420, I don't know which set the live API sends, so nothing was removed

Where this leaves the gap report

After this chain merges, Find-MissingModelMembers.ps1 reports 0 unmapped response members against v1.74.0 (from 155). What it still reports, and what this series did not touch:

  • 140 spec operations not implemented (new endpoints).
  • 214 library endpoints matching no spec path — some removed/renamed by Cisco, some path shapes the normaliser misses, some possibly dead code.

Both need their own pass; the ApiChecker project is the existing tool for the endpoint side.

Verification

dotnet build Meraki.Api.slnx -c Debug   Build succeeded, 0 Error(s)
Meraki.Api.Test (Data namespace)        Total: 61, Errors: 0, Failed: 0   (5 new in LiveToolsGeneralMemberTests)
Meraki.Api.Test (Workflows)             Total: 12, Errors: 0, Failed: 0

All 13 edited files kept their BOM state.

Nineteen members the v1.74.0 spec documents that the models lacked, the
sixth and last per-area batch, which closes every member the report listed:
Client.Cdp; ClientProvision.ClientId and .Message; DeviceClient
.AdaptivePolicyGroup and .Switchport; Mac on both MAC-table request types;
IpVersion, Vrf and VrfType on the multicast routing interface and route
types; Events.ClientMac; LiveToolsArpTableResultTableEntry.Interface;
LiveToolsThroughputTestCreateResponse.ThroughputTestId; and the API's
current startTime/endTime and received names alongside the legacy ones on
LossAndLatencyHistory, SubclassApplicationUsage and SubclassUsageHistory.

Find-MissingModelMembers.ps1 now reports no unmapped response members
against v1.74.0. LiveToolsGeneralMemberTests covers the batch.
With every member mapped, the summary line indexed .ClrType on an empty
array, which Set-StrictMode rejects. Count the types only when there are
findings.
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 7 complexity

Metric Results
Complexity 7

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant