Skip to content

🧹 chore: run dagger call with --cloud - #38

Merged
jpmcb merged 1 commit into
mainfrom
ci/dagger-cloud
Sep 24, 2026
Merged

jpmcb merged 1 commit into
mainfrom
ci/dagger-cloud

Conversation

@jpmcb

@jpmcb jpmcb commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

👨🏼

Local DeepSeek fanout.

Refs PCC-1489

🤖

Appends the global --cloud flag to every dagger call invocation in .github/workflows/, so CI runs on Dagger Cloud provisioned engines/machines.

  • Each Dagger step already supplies DAGGER_CLOUD_TOKEN, so no environment changes are needed.
  • The flag is placed at the end of each command, after all module/function flags, matching the existing dagger call test --silent --cloud convention.

Appends the global `--cloud` flag to every `dagger call` invocation in `.github/workflows/`, so CI runs on Dagger Cloud provisioned engines/machines.

- Each Dagger step already supplies `DAGGER_CLOUD_TOKEN`, so no environment changes are needed.
- The flag is placed at the end of each command, after all module/function flags, matching the existing `dagger call test --silent --cloud` convention.
@jpmcb jpmcb changed the title ci: run dagger call with --cloud 🧹 chore: run dagger call with --cloud Sep 24, 2026
@jpmcb
jpmcb marked this pull request as ready for review September 24, 2026 21:55
@jpmcb
jpmcb merged commit 04fb13a into main Sep 24, 2026
11 of 13 checks passed
@jpmcb
jpmcb deleted the ci/dagger-cloud branch September 24, 2026 21:55
@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown

PCC-1489

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR should not merge until forked pull requests can still run the required metadata checks without a Cloud credential.

Findings

  1. P1 Fork PR checks need Cloud access ▶
Fix with agent prompt
### Issue 1
.github/workflows/pr.yaml:55
Forked pull requests cannot receive the repository's `DAGGER_CLOUD_TOKEN`, but this call now requests Cloud execution unconditionally. If the Dagger CLI requires that token for `--cloud`, the title check will fail before it can validate an otherwise valid PR. The Linear-reference check has the same change at line 80. Keep a local execution path when the token is unavailable.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary

The PR adds --cloud to the two direct Dagger calls that enforce pull-request title and Linear-reference policy.

  • Both policy gates now depend on Cloud access, including for forked pull requests that cannot receive the Cloud secret.

Reviews (1) · Last reviewed commit: "ci: run dagger call with --cloud"

Comment thread .github/workflows/pr.yaml
--repo="${{ github.repository }}" \
check-pull-request \
--number "${{ github.event.pull_request.number }}"
--number "${{ github.event.pull_request.number }}" --cloud

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Fork PR checks need Cloud access

Forked pull requests cannot receive the repository's DAGGER_CLOUD_TOKEN, but this call now requests Cloud execution unconditionally. If the Dagger CLI requires that token for --cloud, the title check will fail before it can validate an otherwise valid PR. The Linear-reference check has the same change at line 80. Keep a local execution path when the token is unavailable.

Knowledge Base Used: Continuous integration workflows

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/pr.yaml
Line: 55

Comment:
**Fork PR checks need Cloud access**

Forked pull requests cannot receive the repository's `DAGGER_CLOUD_TOKEN`, but this call now requests Cloud execution unconditionally. If the Dagger CLI requires that token for `--cloud`, the title check will fail before it can validate an otherwise valid PR. The Linear-reference check has the same change at line 80. Keep a local execution path when the token is unavailable.

**Knowledge Base Used:** [Continuous integration workflows](https://app.greptile.com/paper-compute/-/custom-context/knowledge-base/papercomputeco/daggerverse/-/docs/continuous-integration-workflows.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant