fix: show search, undo, and patch-merge results without trace - #237
Merged
Conversation
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Search, search -L, and undo toasts point at the Patchloom channel, but executePatchloom only writes stdout when patchloom.trace.server is verbose (default off). Always append those user-facing streams via writeUserVisibleOutput before show(). Other CLI I/O still follows trace.server. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Present search, undo, and patch-merge CLI streams through a shared helper so default trace=off still shows results, including exit 8 conflicts. Unit tests lock the presenters, not only the log helper. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 00:39
SebTardif
enabled auto-merge (squash)
August 28, 2026 00:39
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search, search
-L, undo, and patch-merge now write CLI stdout/stderr to the Patchloom output channel even whenpatchloom.trace.serverisoff. Patch-merge conflict details (exit 8) are included. UI and agent-rules tests fail on leftover toasts or argv-blind mocks.Why
With the default trace level, search and undo showed an empty output channel. Patch merge told users to check the output for conflict details and then opened that empty channel.
The change
writeUserVisibleOutput/presentCliResultInOutputwrite streams regardless of trace-L, undo, and patch-merge (success and exit 8) go through exported presentersup_to_datere-runs generate and checks the execFile argvVerification
npm run check(357 passed, 6 skipped)Checklist
git commit -snpm run checkand it passes